chore: [IOPID-991] Integration of email validation logic in the onboarding flow and profile preferences flow #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladirico
changed the title
…ica-email-nelle-preferenze
pagopa-github-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5206 +/- ##
==========================================
- Coverage 48.00% 47.86% -0.14%
==========================================
Files 1565 1567 +2
Lines 32398 32494 +96
Branches 7947 7979 +32
==========================================
+ Hits 15553 15554 +1
- Misses 16795 16890 +95
Partials 50 50
Continue to review full report in Codecov by Sentry.
|
Ladirico
commented
Nov 8, 2023
AliceAzzolini
approved these changes
Nov 9, 2023
Co-authored-by: Alice Azzolini <[email protected]>
Co-authored-by: Alice Azzolini <[email protected]>
Co-authored-by: Alice Azzolini <[email protected]>
…ica-email-nelle-preferenze
…ica-email-nelle-preferenze
## Short description
This pr adds the logic that allows the app not to show the biometric
activation request if it has already been activated in a previous login
and adds, in the case of FACE_ID, the prompt requesting permissions upon
activation.
## List of changes proposed in this pull request
-
ts/sagas/startup/onboarding/biometric/checkAcknowledgedFingerprintSaga.ts:
added check to see if it had been activated in the last login.
- [ts/screens/onboarding/biometric&securityChecks/FingerprintScreen.tsx
, ts/screens/profile/SecurityScreen.tsx] : added permission request
prompt in case of faceid.
- ts/store/reducers/index.ts: biometric preference persisted to get it
also after the end of a session.
- ts/store/reducers/onboarding.ts: added reset of biometric control also
after session expired.
- ts/store/reducers/persistedPreferences.ts: added cross session
control.
- ts/utils/biometrics.ts: added function that handles the biometric
activation.
## How to test
With a new installation, try activating biometrics during onboarding:
- If the biometric is not FaceID, it should activate (or not) the
feature without prompting.
- If the biometric is FaceID, when the active button is pressed, it
should present the request for permissions:
- If you give permissions and the authentication fails, it should not
proceed.
- If you give permissions and the authentication is successful, it
should proceed and enable the feature.
- If you don't give permissions, it should proceed and not activate the
feature.
After logout or session expired, if the biometric has been activated
during last session, it should not ask you for activation again after
login, unless this is done with a different account than the previous
one.
---------
Co-authored-by: Fabio Bombardi <[email protected]>
Co-authored-by: Cristiano Tofani <[email protected]>
…ils screen (#5209) ## Short description This PR fixes the ID Pay initiative rules info bottom sheet height for shorter contents. https://github.com/pagopa/io-app/assets/6160324/7ffc63cf-82d8-4349-a55a-651157537887 ## List of changes proposed in this pull request - [ts/features/idpay/details/components/InitiativeRulesInfoBox.tsx](https://github.com/pagopa/io-app/compare/IOBP-361-fix-idpay-rules-bottom-sheet?expand=1#diff-aec7df12aad70c4276336c3813019b4655fac37dc09eb456b93208f7c6b8b302): increased bottom padding to `170` for the rules bottom sheet - [ts/features/idpay/details/components/BeneficiaryDetailsContent.tsx](https://github.com/pagopa/io-app/compare/IOBP-361-fix-idpay-rules-bottom-sheet?expand=1#diff-763f13f0b9f72e4763aa758664939937121a62cc637c86ff29bfe6f41ab7d56c): component props refactoring ## How to test Navigate to the ID Pay initiative details screen and check that the rules bottom sheet is correctly displayed. Co-authored-by: Alessandro Izzo <[email protected]>
…ica-email-nelle-preferenze
…re mark the PR as ready for review
|
🎉 All dependencies have been resolved ! |
…ica-email-nelle-preferenze
…ica-email-nelle-preferenze
shadowsheep1
requested changes
Nov 27, 2023
Ladirico
deleted the
IOPID-991-app-integrazione-schermata-modifica-email-nelle-preferenze
branch
Ladirico
added a commit
that referenced
this pull request
Dec 4, 2023
##⚠️ Depends on #5206⚠️ ## ## Short description This PR blocks the user if their email is not verified or is already taken, forcing them to validate or change it. The flow is described in this [Figma](https://www.figma.com/file/oLJMcWd0SbRHDtj7WRvu7N/Univocit%C3%A0-indirizzi-email?type=design&node-id=31-12161&mode=design&t=np5Q8HLkqXhrq6ey-4). ## List of changes proposed in this pull request - The two modal `ValidateEmailModal` and `EmailAlreadyUsedModal` has been changed to their sibling screen component `ValidateEmailScreen` and `EmailAlreadyTakenScreen` to use the navigation capabilities. - A new redux state has been added to `EmailValidationState` to know if we are landing to `EmailInsertScreen` from the standard flow or because the user has been block during the startup process. ## How to test Enable the `new CDU flow` and using the `io-dev-api-server` try to: - Enter the app as a new user (firstOnboardig: true) and see that you are blocked until you have validated your email. Even if you reload the app. - Change your email in the profile section and see that you are blocked until you have validated your email, even if you reload the app. - Try to invalidate the email and set it as "already taken", and restart the app. You should see that you are blocked until you have changed and successfully validated the new email, even if you reload the app. > At app startup if `isEmailValidated=true` the user can continue without problems, otherwise if `isEmailValidated=false` the user sees `ValidateEmailScreen` or `EmailAlreadyTakenScreen` based on the value of `isEmailAlreadyTaken`. <details open><summary>Details</summary> <p> <video src="https://github.com/pagopa/io-app/assets/16268789/6aa4156e-71e0-4cc1-9071-19fafbe8bbc8" /> </p> </details> --------- Co-authored-by: Alice Di Rico <[email protected]> Co-authored-by: Alice Azzolini <[email protected]> Co-authored-by: Sabino <[email protected]> Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Andrea Piai <[email protected]> Co-authored-by: Federico Mastrini <[email protected]> Co-authored-by: Alessandro Izzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
In this PR, I integrated business logic that allows the validation of the email within both the onboarding and profile editing screens.
List of changes proposed in this pull request
NewEmailInsertScreen.tsxNewOnboardingEmailInsertScreen.tsxProfileErrorType.tsNewOptInScreen.tsxOnboarding Flow
Registrazione.schermo.2023-11-22.alle.11.41.15.mov
How to test
firstOnboarding: trueis_email_validated: true.is_email_already_taken: trueif you need to display the alert on the screen NewEmailInsertScreen.[email protected].Change preferences flow
Registrazione.schermo.2023-11-22.alle.12.04.29.mov
How to test
Once logged in, go to your profile and select 'your data'. From here you can edit your email. The flow is almost the same as explained above (from point 7)