Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOPID-1257] Fix: no-mail user onboarding #5338

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Dec 14, 2023

Short description

This PR fix an edge case that is present, if a profile coming from BE has an empty email (like with EIC) and the user restart the app, thus restarting their onboarding.

Details

correct flow
no-email-flow.mov

How to test

With this io-dev-server PR, start with a profile without email. When prompt to insert your email, restart the app. You should be block until you set and validate a non empty email.

@shadowsheep1 shadowsheep1 self-assigned this Dec 14, 2023
@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label Dec 14, 2023
@pagopa-github-bot pagopa-github-bot changed the title [IOPID-1257] fix: no-mail user onboarding fix: [IOPID-1257] Fix: no-mail user onboarding Dec 14, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 14, 2023

Affected stories

  • 🐞 IOPID-1257: Edge case - profilo utente senza email

Generated by 🚫 dangerJS against 641f5f6

@shadowsheep1 shadowsheep1 marked this pull request as ready for review December 14, 2023 14:58
@shadowsheep1 shadowsheep1 requested a review from a team as a code owner December 14, 2023 14:58
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #5338 (dc8b563) into master (10cab8e) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 31.25%.

❗ Current head dc8b563 differs from pull request most recent head 641f5f6. Consider uploading reports for the commit 641f5f6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5338      +/-   ##
==========================================
- Coverage   47.82%   47.81%   -0.01%     
==========================================
  Files        1626     1626              
  Lines       33770    33779       +9     
  Branches     8279     8285       +6     
==========================================
+ Hits        16150    16151       +1     
- Misses      17565    17572       +7     
- Partials       55       56       +1     
Files Coverage Δ
ts/hooks/useSecuritySuggestionBottomSheet.tsx 80.00% <100.00%> (-3.34%) ⬇️
ts/features/fastLogin/saga/utils/index.ts 21.42% <0.00%> (-1.65%) ⬇️
ts/sagas/profile.ts 20.47% <0.00%> (-0.33%) ⬇️
ts/sagas/startup.ts 34.46% <0.00%> (ø)
ts/sagas/startup/checkAcknowledgedEmailSaga.ts 85.71% <33.33%> (-14.29%) ⬇️
ts/sagas/user/userDataProcessing.ts 78.57% <50.00%> (-4.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee48c2e...641f5f6. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowsheep1 shadowsheep1 merged commit 47aa4a0 into master Dec 14, 2023
6 checks passed
@shadowsheep1 shadowsheep1 deleted the IOPID-1257-fix-no-mail-user branch December 14, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants