-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [IOPID-1257] Fix: no-mail user onboarding #5338
Conversation
Affected stories
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5338 +/- ##
==========================================
- Coverage 47.82% 47.81% -0.01%
==========================================
Files 1626 1626
Lines 33770 33779 +9
Branches 8279 8285 +6
==========================================
+ Hits 16150 16151 +1
- Misses 17565 17572 +7
- Partials 55 56 +1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR fix an edge case that is present, if a profile coming from BE has an empty email (like with EIC) and the user restart the app, thus restarting their onboarding.
Details
no-email-flow.mov
How to test
With this io-dev-server PR, start with a profile without email. When prompt to insert your email, restart the app. You should be block until you set and validate a non empty email.