Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-695] Add banner of service to payments home screen #5855

Merged
merged 15 commits into from
Jun 19, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Jun 12, 2024

⚠️ This PR depends on pagopa/io-services-metadata#787 ⚠️

Short description

This PR adds the ability to display a remote alert (formally called a banner) within the home payment screen.

List of changes proposed in this pull request

  • Created a new PaymentsAlertStatus component that takes the payments section status to show/hide a banner;
  • Updated io_content_specs definitions into package.json -> WARNING: As soon as the chore: [IOBP-696] Add payments section banner definitions io-services-metadata#787 PR is merged, the content definition reference will have the 1.0.33 version
  • Created a utility function getAlertVariant in order to "normalize" the alert variant based on the SectionStatus LevelEnum;

How to test

Preview

Fade In Fade Out
fadein.mov
fadeout.mov

@Hantex9 Hantex9 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jun 12, 2024
@Hantex9 Hantex9 requested review from thisisjp and a team as code owners June 12, 2024 14:25
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jun 12, 2024

Affected stories

  • ⚙️ IOBP-695: Implementazione banner di servizio con link "esterno"
    subtask of
    • 🌟 IOBP-663: Implementazione banner di servizio su nuova landing Pagamenti

Generated by 🚫 dangerJS against 01b4f53

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 49.52%. Comparing base (4f204b4) to head (01b4f53).
Report is 180 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5855      +/-   ##
==========================================
+ Coverage   48.42%   49.52%   +1.09%     
==========================================
  Files        1488     1696     +208     
  Lines       31617    33538    +1921     
  Branches     7669     8096     +427     
==========================================
+ Hits        15311    16609    +1298     
- Misses      16238    16869     +631     
+ Partials       68       60       -8     
Files Coverage Δ
...tures/payments/home/screens/PaymentsHomeScreen.tsx 95.00% <100.00%> (+0.55%) ⬆️
...s/payments/home/components/PaymentsAlertStatus.tsx 33.33% <33.33%> (ø)
ts/features/payments/common/utils/index.ts 41.33% <10.00%> (+1.67%) ⬆️

... and 772 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e689f...01b4f53. Read the comment docs.

Copy link

dpulls bot commented Jun 19, 2024

🎉 All dependencies have been resolved !

@Hantex9 Hantex9 merged commit 71b76b4 into master Jun 19, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-695-add-banner-of-service-payments branch June 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants