Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-982] Add outcome 99 screen into payment flow #6424

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Nov 19, 2024

Short description

This PR adds outcome 99 inside the payment screen when receiving it from the backend.

List of changes proposed in this pull request

  • Created a custom BE_NODE_KO that's equals to outcome 99;
  • Mapped the new outcome inside the labels and the screen to show into the WalletPaymentOutcomeScreen.tsx file;
  • Added missing outcomes to keep track on mixpanel inside the getPaymentAnalyticsEventFromFailureOutcome function

How to test

Preview

preview.mov

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 19, 2024

Affected stories

  • ⚙️ IOBP-982: [FE - Esito] Implementare nuova schermata d'errore per disservizi BE/nodo
    subtask of
    • 🌟 IOBP-941: [Flusso di pagamento] Miglioramento schermate d'errore/outcome in fase di verifica/attivazione ed autorizzazione (errore non gestito + generic_error)

Generated by 🚫 dangerJS against 262084e

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested positively 💫

‼️Check the test before merge‼️

@thisisjp
Copy link
Contributor

@Hantex9 the module doesn't seem vertically aligned, isn't it? 🤔

@Hantex9
Copy link
Contributor Author

Hantex9 commented Nov 19, 2024

@Hantex9 the module doesn't seem vertically aligned. 🤔

It isn't aligned vertically and I realized that due to some changes addressed to the OperationResultScreenContent, the content is aligned vertically only when provided the property isHeaderVisible as implemented in the following commit that solves the UI issue: e767f85

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.73%. Comparing base (4f204b4) to head (262084e).
Report is 738 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6424      +/-   ##
==========================================
- Coverage   48.42%   47.73%   -0.69%     
==========================================
  Files        1488     1609     +121     
  Lines       31617    32256     +639     
  Branches     7669     7392     -277     
==========================================
+ Hits        15311    15399      +88     
- Misses      16238    16815     +577     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
ts/features/payments/checkout/analytics/index.ts 54.60% <100.00%> (ø)
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 80.76% <100.00%> (+79.20%) ⬆️
...ures/payments/checkout/types/PaymentOutcomeEnum.ts 100.00% <ø> (+75.00%) ⬆️

... and 1652 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795040d...262084e. Read the comment docs.

---- 🚨 Try these New Features:

@Hantex9 Hantex9 merged commit 3c211b6 into master Nov 20, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-982-add-outcome-99 branch November 20, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants