Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-964] Add zendesk payment subcategories #6522

Merged
merged 27 commits into from
Dec 11, 2024

Conversation

LeleDallas
Copy link
Contributor

Warning

this PR depends on pagopa/io-services-metadata#892
this PR depends on pagopa/io-dev-api-server#446

Short description

This pull request includes the addition of a new API request type for fetching Zendesk payment configuration, updates to the Redux store and sagas to handle this new configuration, and modifications to the payment failure support modal to utilize the new configuration.

List of changes proposed in this pull request

  • Added a new type GetZendeskPaymentConfigT and a corresponding API request getZendeskPaymentConfig to fetch the Zendesk payment configuration
  • handleGetZendeskPaymentConfig to manage the side effects of fetching the Zendesk payment configuration and integrated it into the watchZendeskSupportSaga
  • Updated the payment failure support modal to dispatch the getZendeskPaymentConfig action and utilize the fetched configuration to set custom fields for Zendesk tickets

How to test

Ensure that the outcomes are accurately mapped to the corresponding subcategory when opening a ticket

@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Dec 9, 2024
@pagopa-github-bot pagopa-github-bot changed the title feat: [IOBP-964] Add zendesk payment subcategories chore: [IOBP-964] Add zendesk payment subcategories Dec 9, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 9, 2024

Affected stories

  • ⚙️ IOBP-964: [FE] Adeguamento schermate app IO a nuove sotto-categorie Zendensk
    subtask of
    • 🌟 IOBP-934: [Contatta assistenza] Adeguamento logiche di FE a nuova alberatura categorie Zendesk "Pagamenti"

Generated by 🚫 dangerJS against b8cc047

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 41.30435% with 27 lines in your changes missing coverage. Please review.

Project coverage is 49.03%. Comparing base (4f204b4) to head (b8cc047).
Report is 867 commits behind head on master.

Files with missing lines Patch % Lines
...k/saga/networking/handleGetZendeskPaymentConfig.ts 0.00% 10 Missing ⚠️
...s/checkout/hooks/usePaymentFailureSupportModal.tsx 25.00% 9 Missing ⚠️
ts/features/zendesk/store/reducers/index.ts 55.55% 4 Missing ⚠️
ts/api/content.ts 25.00% 3 Missing ⚠️
ts/features/zendesk/saga/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6522      +/-   ##
==========================================
+ Coverage   48.42%   49.03%   +0.60%     
==========================================
  Files        1488     1549      +61     
  Lines       31617    31919     +302     
  Branches     7669     7221     -448     
==========================================
+ Hits        15311    15651     +340     
+ Misses      16238    16229       -9     
+ Partials       68       39      -29     
Files with missing lines Coverage Δ
ts/features/payments/checkout/utils/index.ts 95.65% <100.00%> (-4.35%) ⬇️
...tures/zendesk/screens/ZendeskSupportHelpCenter.tsx 74.25% <100.00%> (+1.94%) ⬆️
ts/features/zendesk/store/actions/index.ts 100.00% <100.00%> (ø)
ts/utils/supportAssistance.ts 92.53% <100.00%> (ø)
ts/features/zendesk/saga/index.ts 2.70% <0.00%> (-2.30%) ⬇️
ts/api/content.ts 23.07% <25.00%> (+0.21%) ⬆️
ts/features/zendesk/store/reducers/index.ts 69.69% <55.55%> (-15.09%) ⬇️
...s/checkout/hooks/usePaymentFailureSupportModal.tsx 47.76% <25.00%> (+45.72%) ⬆️
...k/saga/networking/handleGetZendeskPaymentConfig.ts 0.00% <0.00%> (ø)

... and 1711 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7eca8a...b8cc047. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeleDallas LeleDallas merged commit 86043f0 into master Dec 11, 2024
12 checks passed
@LeleDallas LeleDallas deleted the IOBP-964-zendesk-subcategory-adjustment branch December 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants