Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIW-1455] Reissuing expired or expiring eID #6580

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Merge branch 'master' into SIW-1455-credential-expiry-and-reissuing

69c0547
Select commit
Loading
Failed to load commit list.
Open

[SIW-1455] Reissuing expired or expiring eID #6580

Merge branch 'master' into SIW-1455-credential-expiry-and-reissuing
69c0547
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

49.59% (-0.02%) compared to 93bd0a8

View this Pull Request on Codecov

49.59% (-0.02%) compared to 93bd0a8

Details

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.59%. Comparing base (93bd0a8) to head (69c0547).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/itwallet/machine/credential/guards.ts 10.00% 9 Missing ⚠️
...ns/ItwPresentationEidVerificationExpiredScreen.tsx 12.50% 7 Missing ⚠️
ts/features/itwallet/machine/credential/actions.ts 0.00% 2 Missing ⚠️
ts/features/itwallet/machine/eid/machine.ts 60.00% 2 Missing ⚠️
...twallet/common/components/ItwEidLifecycleAlert.tsx 66.66% 1 Missing ⚠️
...n/screens/ItwIdentificationModeSelectionScreen.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6580      +/-   ##
==========================================
- Coverage   49.61%   49.59%   -0.02%     
==========================================
  Files        1564     1565       +1     
  Lines       32370    32393      +23     
  Branches     7332     7290      -42     
==========================================
+ Hits        16059    16065       +6     
- Misses      16263    16291      +28     
+ Partials       48       37      -11     
Files with missing lines Coverage Δ
...common/components/ItwEidInfoBottomSheetContent.tsx 70.83% <ø> (ø)
ts/features/itwallet/machine/credential/machine.ts 92.30% <ø> (-0.55%) ⬇️
ts/features/itwallet/machine/eid/actions.ts 1.49% <ø> (ø)
ts/features/itwallet/machine/eid/context.ts 100.00% <ø> (ø)
...features/itwallet/navigation/ItwStackNavigator.tsx 36.36% <ø> (ø)
ts/features/itwallet/navigation/routes.ts 100.00% <ø> (ø)
...eatures/wallet/components/WalletCardsContainer.tsx 100.00% <ø> (ø)
...twallet/common/components/ItwEidLifecycleAlert.tsx 84.21% <66.66%> (-4.03%) ⬇️
...n/screens/ItwIdentificationModeSelectionScreen.tsx 79.41% <83.33%> (+0.10%) ⬆️
ts/features/itwallet/machine/credential/actions.ts 0.00% <0.00%> (ø)
... and 3 more

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bd0a8...69c0547. Read the comment docs.