Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-2556] io-lollipop integration tests #143

Merged
merged 29 commits into from
Dec 18, 2024
Merged

[#IOPID-2556] io-lollipop integration tests #143

merged 29 commits into from
Dec 18, 2024

Conversation

salvatorelaiso
Copy link
Collaborator

@salvatorelaiso salvatorelaiso commented Dec 13, 2024 •
edited
Loading

List of Changes

  • Migrate io-lollipop integration tests from jest to vitest
  • Fix io-lollipop integration test execution
  • Run io-lollipop integration tests in code review pipeline
  • Update environment management for containers

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1e78a88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2556

arcogabbo
arcogabbo requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@arcogabbo arcogabbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am leaving a bunch of comments even if it's still in draft. I feel some of the comments require discussion.

apps/io-lollipop/src/__integrations__/__tests__/activatePubKey.test.ts Outdated Show resolved Hide resolved
apps/io-lollipop/src/__integrations__/vite.config.mts Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker/cosmosdb/Dockerfile Outdated Show resolved Hide resolved
docker/functions-node-20/Dockerfile Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker/io-lollipop/Dockerfile Outdated Show resolved Hide resolved
docker/io-lollipop/env-dev Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Salvatore Laiso and others added 20 commits December 18, 2024 09:34
fix: steps order
c741e62
@salvatorelaiso @arcogabbo
Update docker-compose.yml
1e6dfa9 
Co-authored-by: Gabriele Mendolia <[email protected]>
fix: env file for e2e tests
f8732d3
fix: traefik env
39b6626
fix: suppress warning on docker compose down variable not set
bb25549
feat: run integration tests in code review pipeline
53ebc3b
fix: services startup in code review pipeline
be0dde4
@salvatorelaiso @arcogabbo
Update package.json
1f02abb 
Co-authored-by: Gabriele Mendolia <[email protected]>
fix: simplify environment
3a6caec
@salvatorelaiso @arcogabbo
Update apps/io-lollipop/src/__integrations__/vite.config.mts
edee68f 
Co-authored-by: Gabriele Mendolia <[email protected]>
@salvatorelaiso @arcogabbo
Update docker/cosmosdb/Dockerfile
4ee42c7 
Co-authored-by: Gabriele Mendolia <[email protected]>
@salvatorelaiso @arcogabbo
Update docker/functions-node-20/Dockerfile
9a96c20 
Co-authored-by: Gabriele Mendolia <[email protected]>
@salvatorelaiso @arcogabbo
Update docker-compose.yml
4c1a04f 
Co-authored-by: Gabriele Mendolia <[email protected]>
fix: use BASE_URL from env.ts in activatePubKey.test.ts
f737061
fix: smaller Docker image
6efbf0f
fix(build): solve func error
6ce5afa
fix(test): copy src folder
71416d9
fix(build): change base
e4dd73f
temp: use base
3de25ef
fix: Docker runner image
1e78a88
@salvatorelaiso salvatorelaiso changed the title [#IOPID-2556] [#IOPID-2556] io-lollipop integration tests Dec 18, 2024
@salvatorelaiso salvatorelaiso marked this pull request as ready for review December 18, 2024 16:38
@salvatorelaiso salvatorelaiso requested review from a team as code owners December 18, 2024 16:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Lollipop'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@salvatorelaiso salvatorelaiso merged commit 783f3a1 into main Dec 18, 2024
9 checks passed
@salvatorelaiso salvatorelaiso deleted the IOPID-2556 branch December 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati left review comments

@arcogabbo arcogabbo arcogabbo approved these changes

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salvatorelaiso @BurnedMarshal @arcogabbo @gquadrati