Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-283] new wallet onboarding apis #310

Merged
merged 9 commits into from
Oct 24, 2023

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Oct 18, 2023

Short description

This PR introduces the new changes made for the new onboarding wallet flow.

List of changes proposed in this pull request

  • Created a new api for the /payment-methods GET in order to retrieve a list of all available payment methods that the user can onboard,
  • Adapted the existing api for the onboarding start in order to give also a walletId when the outcome of the webview is a success one.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #310 (9b05118) into master (fffadd0) will decrease coverage by 0.64%.
Report is 6 commits behind head on master.
The diff coverage is 64.32%.

❗ Current head 9b05118 differs from pull request most recent head 9d97547. Consider uploading reports for the commit 9d97547 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   68.55%   67.92%   -0.64%     
==========================================
  Files         134      143       +9     
  Lines        4777     4951     +174     
  Branches      612      618       +6     
==========================================
+ Hits         3275     3363      +88     
+ Misses       1501     1494       -7     
- Partials        1       94      +93     
Files Coverage Δ
src/config.ts 96.00% <100.00%> (ø)
.../features/messages/persistence/messagesDatabase.ts 95.16% <100.00%> (ø)
src/features/messages/types/liveModeMessages.ts 100.00% <100.00%> (ø)
src/features/messages/types/messagesConfig.ts 100.00% <100.00%> (ø)
src/features/pn/payloads/messages.ts 77.77% <100.00%> (+1.93%) ⬆️
src/features/pn/types/messageTemplate.ts 100.00% <100.00%> (ø)
src/features/pn/types/messageTemplateWrapper.ts 100.00% <100.00%> (ø)
src/payloads/backend.ts 100.00% <ø> (ø)
src/populate-persistence.ts 82.24% <100.00%> (ø)
src/routers/features/walletV3/onboarding/data.ts 100.00% <100.00%> (ø)
... and 22 more

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb31bc...9d97547. Read the comment docs.

@Hantex9 Hantex9 marked this pull request as ready for review October 19, 2023 13:47
@Hantex9 Hantex9 requested a review from a team as a code owner October 19, 2023 13:47
@Hantex9 Hantex9 marked this pull request as draft October 23, 2023 12:31
@Hantex9 Hantex9 marked this pull request as ready for review October 23, 2023 14:22
@Hantex9 Hantex9 merged commit f977b5b into master Oct 24, 2023
4 checks passed
@Hantex9 Hantex9 deleted the IOBP-283-new-wallet-onboarding-apis branch October 24, 2023 14:13
Hantex9 added a commit to pagopa/io-app that referenced this pull request Oct 25, 2023
…ethod (#5137)

## ⚠️ This PR depends on
pagopa/io-app-design-system#111
## ⚠️ This PR depends on
pagopa/io-dev-api-server#310
## Short description
This PR introduces the new select payment method process into wallet
onboarding flow showing a list of all available payment methods and when
selecting one of them, it redirects to the webview page giving the
payment method selected as property in order to start the onboarding
process on the webview.

## List of changes proposed in this pull request
- Updated swagger definitions into package.json with the new one
provided;
- Created new `WalletOnboardingPaymentMethodsList` component to show a
list of available payment methods;
- Created relative saga, actions and reducer to retrieve from the API a
list of all available payment methods;
- Setupped the navigation param `paymentMethodId` into Wallet Onboarding
start screen with webview in order to start the onboarding process for
the selected payment method.
- Upgraded the design system library to the version `1.14.0`

**NB:** This PR handles only the first page to select an available
payment method from the list, other screens will be managed in another
PR with a new Jira task
([IOBP-284](https://pagopa.atlassian.net/browse/IOBP-284))

## How to test
Describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce.

## Preview

https://github.com/pagopa/io-app/assets/34343582/fa06d1ae-5c01-4296-8efe-527054e5edaa


[IOBP-284]:
https://pagopa.atlassian.net/browse/IOBP-284?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Jacopo Pompilii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants