Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOBP-347] addition of IDPAY barcode #318

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

forrest57
Copy link
Contributor

Short description

added handling for idpay barcode generation and expire mechanics

List of changes proposed in this pull request

  • added handler for idpay barcode
  • added handler for said barcode expiration

How to test

run a bunch of postman queries for payment/bar-code with {"initiativeId": "..."} as body

@forrest57 forrest57 requested a review from a team as a code owner November 10, 2023 11:22
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #318 (fe26d5d) into master (f1cae90) will decrease coverage by 0.23%.
Report is 3 commits behind head on master.
The diff coverage is 35.29%.

❗ Current head fe26d5d differs from pull request most recent head cea6f0d. Consider uploading reports for the commit cea6f0d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   67.93%   67.71%   -0.23%     
==========================================
  Files         143      144       +1     
  Lines        4950     4984      +34     
  Branches      599      603       +4     
==========================================
+ Hits         3363     3375      +12     
- Misses       1586     1608      +22     
  Partials        1        1              
Files Coverage Δ
src/routers/features/idpay/index.ts 100.00% <100.00%> (ø)
src/routers/features/idpay/barcode.ts 47.05% <47.05%> (ø)
src/persistence/idpay.ts 71.42% <18.75%> (-5.82%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284edc2...cea6f0d. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 merged commit 4f7bdf1 into master Nov 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants