chore: [IOBP-408] Added iowallet:// as custom url schema to provide outcome
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 67.73% 67.73%
=======================================
Files 144 144
Lines 5009 5009
Branches 587 587
=======================================
Hits 3393 3393
Misses 1615 1615
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
mastro993
approved these changes
Nov 23, 2023
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
Nov 29, 2023
##⚠️ Depends on #5189 and pagopa/io-dev-api-server#320⚠️ ## Short description This PR changes the new wallet onboarding flow using the custom web view implemented by Authentication team, ensuring an improved and fulfilling user experience. ## List of changes proposed in this pull request - Removed the previous `WalletOnboardingWebView` component - Added a new custom hook `useWalletOnboardingWebView` which implements all the business logic to start an onboarding process showing the custom webview. It gives a function `startOnboarding` which accept as input the paymentMethodId and whenever the webview is closed, it emit an `onSuccess` or `onFailure` or `onError` or `onDismiss` event, in this way this hook can be more flexible and reusable in other flows (such as the payment flow) - Edited the previous `WalletOnboardingStartScreen` to `WalletOnboardingFeedbackScreen` which shows a screen with the relative result screen page ## How to test - Checkout this PR on dev-server: pagopa/io-dev-api-server#320 - Open the `New wallet playground` section; - Start the onboarding flow; - Select a payment method into the list - It will shows a webview into a modal, select the outcome desidred and check that the feedback page is correct ## Preview https://github.com/pagopa/io-app/assets/34343582/27852172-576e-464d-be4e-71394f3ec488 --------- Co-authored-by: Jacopo Pompilii <[email protected]> Co-authored-by: Martino Cesari Tomba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the
iowallet://as custom url schema into onboarding wallet flow to provide the outcome selectedList of changes proposed in this pull request
iowallet://in order to be triggered as callback to the custom webview implemented inside the app