Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-421] Added additional outcome to handle already onboarded method #324

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Nov 28, 2023

Short description

This PR adds into dropdown list into mock web onboarding page an additional outcome that stands for an already onboarded method error

List of changes proposed in this pull request

  • Added into dropdown list of html wallet_onboarding.html page the additional outcome ALREADY_ONBOARDED

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #324 (b47cbf6) into master (5eabdb0) will increase coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 97.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   67.91%   67.94%   +0.02%     
==========================================
  Files         154      154              
  Lines        5205     5209       +4     
  Branches      607      627      +20     
==========================================
+ Hits         3535     3539       +4     
+ Misses       1669     1571      -98     
- Partials        1       99      +98     
Files Coverage Δ
src/payloads/features/idpay/check-prerequisites.ts 100.00% <100.00%> (ø)
src/payloads/features/idpay/get-initiative-data.ts 100.00% <ø> (ø)
src/payloads/features/idpay/types.ts 100.00% <100.00%> (ø)
src/routers/features/idpay/onboarding.ts 97.72% <100.00%> (+0.10%) ⬆️
src/payloads/features/idpay/onboarding-status.ts 91.66% <0.00%> (ø)

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12665f...b47cbf6. Read the comment docs.

@Hantex9 Hantex9 marked this pull request as ready for review December 11, 2023 13:26
@Hantex9 Hantex9 requested a review from a team as a code owner December 11, 2023 13:26
@Hantex9 Hantex9 merged commit 3e7a352 into master Dec 12, 2023
6 checks passed
@Hantex9 Hantex9 deleted the IOBP-421-wallet-already-onboarded-outcome branch December 12, 2023 09:26
Hantex9 added a commit to pagopa/io-app that referenced this pull request Dec 12, 2023
…thods (#5269)

## ⚠️ This PR depends on #5243 and
pagopa/io-dev-api-server#324 ⚠️

## Short description
This PR adds a new outcome screen for an already onboarded payment
method

## List of changes proposed in this pull request
- Added translation locales for the screen;
- Added `ALREADY_ONBOARDED` outcome into enum;
- Added `ALREADY_ONBOARDED` pictogram into definition; 

## How to test
- Checkout pagopa/io-dev-api-server#324 and run
dev-server
- Start the new onboarding process from dev mode playground;
- Select from the dropdown the outcome `ALREADY_ONBOARDED`;
- You should navigate to the correct page showed in the preview below

## Preview
<img
src="https://github.com/pagopa/io-app/assets/34343582/ef560287-7bd3-4f45-a955-0c248f41d9b3"
width="250" />

---------

Co-authored-by: Jacopo Pompilii <[email protected]>
Co-authored-by: Martino Cesari Tomba <[email protected]>
Co-authored-by: Federico Mastrini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants