Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-1181] Add email uniqueness verification FF #329

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Dec 1, 2023

⚠️ Depends on pagopa/io-services-metadata#745 ⚠️

Short description

This PR adds the email uniqueness validation FF.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #329 (02015f4) into master (e795a59) will decrease coverage by 0.14%.
Report is 3 commits behind head on master.
The diff coverage is 64.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   68.00%   67.86%   -0.14%     
==========================================
  Files         149      154       +5     
  Lines        5113     5197      +84     
  Branches      599      599              
==========================================
+ Hits         3477     3527      +50     
- Misses       1635     1669      +34     
  Partials        1        1              
Files Coverage Δ
src/features/wallet/index.ts 100.00% <100.00%> (ø)
src/features/wallet/payloads/paymentMethods.ts 100.00% <100.00%> (ø)
src/features/wallet/persistence/userWallet.ts 95.65% <100.00%> (ø)
src/features/wallet/routers/index.ts 100.00% <100.00%> (ø)
src/features/wallet/routers/router.ts 100.00% <100.00%> (ø)
src/features/wallet/utils/onboarding.ts 75.00% <100.00%> (ø)
src/features/wallet/utils/payment.ts 100.00% <100.00%> (ø)
src/payloads/backend.ts 100.00% <ø> (ø)
src/server.ts 100.00% <100.00%> (ø)
src/routers/public.ts 67.96% <88.88%> (-0.04%) ⬇️
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8c414...02015f4. Read the comment docs.

@shadowsheep1 shadowsheep1 self-assigned this Dec 1, 2023
@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label Dec 1, 2023
@shadowsheep1 shadowsheep1 marked this pull request as ready for review December 1, 2023 14:22
@shadowsheep1 shadowsheep1 requested a review from a team as a code owner December 1, 2023 14:22
Copy link

dpulls bot commented Dec 4, 2023

🎉 All dependencies have been resolved !

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ladirico Ladirico merged commit f3c8fdf into master Dec 5, 2023
6 checks passed
@Ladirico Ladirico deleted the IOPID-1181-cdu-ff branch December 5, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants