Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-451] Add update wallet services API #331

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Dec 11, 2023

Short description

This PR adds the endpoint about the PUT method to the wallet update services;

List of changes proposed in this pull request

  • Updated the open-api definitions;
  • Added the PUT /wallet/:walletid/services API to mock the service wallet update

@Hantex9 Hantex9 requested a review from a team as a code owner December 11, 2023 12:06
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #331 (455158d) into master (5eabdb0) will decrease coverage by 0.18%.
Report is 3 commits behind head on master.
The diff coverage is 68.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   67.91%   67.73%   -0.18%     
==========================================
  Files         154      154              
  Lines        5205     5232      +27     
  Branches      607      628      +21     
==========================================
+ Hits         3535     3544       +9     
+ Misses       1669     1589      -80     
- Partials        1       99      +98     
Files Coverage Δ
src/payloads/features/idpay/check-prerequisites.ts 100.00% <100.00%> (ø)
src/payloads/features/idpay/get-initiative-data.ts 100.00% <ø> (ø)
src/payloads/features/idpay/types.ts 100.00% <100.00%> (ø)
src/routers/features/idpay/onboarding.ts 97.72% <100.00%> (+0.10%) ⬆️
src/payloads/features/idpay/onboarding-status.ts 91.66% <0.00%> (ø)
src/features/wallet/routers/wallets.ts 34.09% <20.00%> (-4.15%) ⬇️
src/features/wallet/persistence/userWallet.ts 69.44% <23.07%> (-26.21%) ⬇️

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7a352...455158d. Read the comment docs.

@Hantex9 Hantex9 merged commit 00c956a into master Dec 12, 2023
6 checks passed
@Hantex9 Hantex9 deleted the IOBP-451-wallet-onboarding-patch branch December 12, 2023 16:39
Hantex9 added a commit to pagopa/io-app that referenced this pull request Dec 12, 2023
)

## Short description
This PR implements a toggle to update the pagoPA capability status
inside the wallet details screen;

## List of changes proposed in this pull request
- Added a new action `walletDetailsPagoPaCapabilityToggle`
- Adapted the `WalletDetailsPagoPaPaymentCapability` component;
- Added a new saga `handleTogglePagoPaCapability` that manages the
toggle of the services that have `PAGOPA` as the service name, updating
the status to `DISABLED` or `ENABLED`
- 
## How to test
- Checkout this PR from io-dev-api-server:
pagopa/io-dev-api-server#331
- Complete the new wallet onboarding process from the `New Wallet
Playground`
- After you add a payment method correctly, you should be able to see
the wallet details with a switch that can be toggled

## Preview


https://github.com/pagopa/io-app/assets/34343582/7884038e-97ab-444e-a02f-e8073e04f1e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants