Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-927] Adapt new openAPI biz-events #423

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Oct 16, 2024

Short description

This PR adapts the new openAPI provided by biz events;

List of changes proposed in this pull request

  • Adapted the new open API of biz-events replacing from "transaction" to "notice";

How to test

Test this PR with the following io-app PR: pagopa/io-app#6187 in dev-env.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 74.62687% with 17 lines in your changes missing coverage. Please review.

Project coverage is 64.33%. Comparing base (e061163) to head (dd831a9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/features/payments/routers/notices.ts 37.50% 10 Missing ⚠️
src/features/payments/persistence/notices.ts 85.36% 6 Missing ⚠️
src/features/payments/routers/payment.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   64.34%   64.33%   -0.01%     
==========================================
  Files         167      167              
  Lines        5354     5350       -4     
  Branches      748      732      -16     
==========================================
- Hits         3445     3442       -3     
+ Misses       1769     1768       -1     
  Partials      140      140              
Files with missing lines Coverage Δ
src/features/payments/routers/index.ts 100.00% <100.00%> (ø)
src/features/payments/routers/router.ts 100.00% <100.00%> (ø)
src/features/payments/utils/transactions.ts 100.00% <100.00%> (ø)
src/features/payments/routers/payment.ts 37.64% <50.00%> (ø)
src/features/payments/persistence/notices.ts 85.36% <85.36%> (ø)
src/features/payments/routers/notices.ts 24.39% <37.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584a724...dd831a9. Read the comment docs.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can remove the ESLint comments and try to solve the errors.

src/features/payments/persistence/notices.ts Outdated Show resolved Hide resolved
src/features/payments/persistence/notices.ts Show resolved Hide resolved
@Hantex9 Hantex9 merged commit b5de21d into master Oct 17, 2024
8 checks passed
@Hantex9 Hantex9 deleted the IOBP-927-adapt-openapi-biz-events branch October 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants