feat: [PE-763] CGN partner search #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 64.04% 63.95% -0.10%
==========================================
Files 167 167
Lines 5399 5412 +13
Branches 739 751 +12
==========================================
+ Hits 3458 3461 +3
+ Misses 1940 1808 -132
- Partials 1 143 +142
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
LeleDallas
approved these changes
Nov 12, 2024
Hantex9
requested changes
Nov 12, 2024
package.json
Outdated
| @@ -8,8 +8,8 @@ | |||
| "io_session_manager_api": "https://raw.githubusercontent.com/pagopa/io-auth-n-identity-domain/[email protected]/apps/io-session-manager/api/internal.yaml", | |||
| "io_session_manager_public_api": "https://raw.githubusercontent.com/pagopa/io-auth-n-identity-domain/[email protected]/apps/io-session-manager/api/public.yaml", | |||
| "api_public_specs": "https://raw.githubusercontent.com/pagopa/io-backend/v14.3.0-RELEASE/api_public.yaml", | |||
| "api_cgn": "https://raw.githubusercontent.com/pagopa/io-backend/v14.3.0-RELEASE/api_cgn.yaml", | |||
| "api_cgn_merchants": "https://raw.githubusercontent.com/pagopa/io-backend/v14.3.0-RELEASE/api_cgn_operator_search.yaml", | |||
| "api_cgn": "https://raw.githubusercontent.com/pagopa/io-backend//refs/tags/v16.2.0-RELEASE/api_cgn.yaml", | |||
There was a problem hiding this comment.
typo here, please edit only the version without adding the refs tags
Suggested change
| "api_cgn": "https://raw.githubusercontent.com/pagopa/io-backend//refs/tags/v16.2.0-RELEASE/api_cgn.yaml", | |
| "api_cgn": "https://raw.githubusercontent.com/pagopa/io-backend/v16.2.0-RELEASE/api_cgn.yaml", |
package.json
Outdated
| "api_cgn": "https://raw.githubusercontent.com/pagopa/io-backend/v14.3.0-RELEASE/api_cgn.yaml", | ||
| "api_cgn_merchants": "https://raw.githubusercontent.com/pagopa/io-backend/v14.3.0-RELEASE/api_cgn_operator_search.yaml", | ||
| "api_cgn": "https://raw.githubusercontent.com/pagopa/io-backend//refs/tags/v16.2.0-RELEASE/api_cgn.yaml", | ||
| "api_cgn_merchants": "https://raw.githubusercontent.com/pagopa/io-backend//refs/tags/v16.2.0-RELEASE/api_cgn_operator_search.yaml", |
There was a problem hiding this comment.
Same here
Suggested change
| "api_cgn_merchants": "https://raw.githubusercontent.com/pagopa/io-backend//refs/tags/v16.2.0-RELEASE/api_cgn_operator_search.yaml", | |
| "api_cgn_merchants": "https://raw.githubusercontent.com/pagopa/io-backend/v16.2.0-RELEASE/api_cgn_operator_search.yaml", |
LeleDallas
added a commit
to pagopa/io-app
that referenced
this pull request
Nov 13, 2024
## Short description Added a partner's search new screen. Refer to screens in https://pagopa.atlassian.net/browse/PE-630 description. See https://pagopa.atlassian.net/browse/PE-758 for no search results screen ## List of changes proposed in this pull request - add labels - remove search functionality in discount list by operators - add new search page ## How to test To test with dev-api-server this PR is needed pagopa/io-dev-api-server#432 I did not made this PR depend on it since it is testable using other backend environments Going to the new search screen option 1: - login into the app - go to CGN card trough wallet (add it if necessary) - press discover opportunities - press magnifying icon in the top bar Going to the new search screen option 2: - login into the app - go to CGN card trough wallet (add it if necessary) - press discover opportunities - go to any category - press magnifying icon in the top bar Testing the search screen - Go to the new search screen - search for partner - check if you see the results - press on a result and check if it opens the correct screen | overview | | - | | <video src="https://github.com/user-attachments/assets/ded627b4-a068-43c3-8a15-c3b8af2ae998"/> | --------- Co-authored-by: Emanuele Dall'Ara <[email protected]> Co-authored-by: Alessandro <[email protected]> Co-authored-by: mariateresaventura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Adds new endpoints for search CGN partners by text
List of changes proposed in this pull request
How to test