Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-2017] FIMS - Implicit consent for internal RP #447

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR adds support for internal Relying Parties, not requiring the user consents to exchange data since (latter) are not sent to a third party entity.

List of changes proposed in this pull request

  • Add a new, optional metadata for Relying Party called isInternal (Boolean). Setting isInternal to true means that the external web services referenced by the client metadata (via redirectUri) is managed by PagoPA S.p.A.
  • Authentication Requests originated by internal Relying Parties no longer require explicit consent by the citizen.

How to test

Test the authentication flow:

  • isInternal: false -> will send the consents data and requires the confirm endpoint to be called
  • isInternal: true -> does not send the consents and automatically follows the entire authentication flow

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (e92e063) to head (6daa4f5).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/features/fims/routers/providerRouter.ts 11.11% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   63.85%   63.75%   -0.11%     
==========================================
  Files         167      166       -1     
  Lines        5437     5410      -27     
  Branches      746      743       -3     
==========================================
- Hits         3472     3449      -23     
+ Misses       1964     1960       -4     
  Partials        1        1              
Files with missing lines Coverage Δ
src/config.ts 96.15% <ø> (ø)
src/features/fims/routers/relyingPartyRouter.ts 15.04% <ø> (ø)
src/features/fims/types/config.ts 100.00% <ø> (ø)
src/features/fims/routers/providerRouter.ts 8.38% <11.11%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d002da3...6daa4f5. Read the comment docs.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth merged commit 0d7758a into master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants