Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAGOPA-2012 handling exception #34

Merged
merged 3 commits into from
Aug 1, 2024
Merged

PAGOPA-2012 handling exception #34

merged 3 commits into from
Aug 1, 2024

Conversation

FedericoRuzzier
Copy link
Contributor

List of Changes

Fixing exception handling after cache retrieval

Motivation and Context

Needed in order not to jump out of a for each statement

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the bug Something isn't working label Aug 1, 2024
@FedericoRuzzier FedericoRuzzier requested a review from a team as a code owner August 1, 2024 08:41
cap-ang
cap-ang approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little note, the other changes LGTM 👍

src/main/java/it/gov/pagopa/reporting/RetrieveFlows.java Outdated Show resolved Hide resolved
@FedericoRuzzier FedericoRuzzier merged commit 7fca080 into main Aug 1, 2024
4 checks passed
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-2012-fix-retrieve-flows branch August 1, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cap-ang cap-ang cap-ang approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@FedericoRuzzier FedericoRuzzier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FedericoRuzzier @cap-ang