Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve GitHub Federated Identity module documentation #181

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

Krusty93
Copy link
Contributor

@Krusty93 Krusty93 commented Nov 6, 2023

List of changes

README.md of the GitHub Federated Identity re-write

Motivation and context

Previous module documentation wasn't clear enough. Several details have been added

Type of changes

  • Add new module
  • Update existing module
  • Remove existing module

Does this introduce a breaking change?

  • Yes
  • No

Other information

Run checks

Useful commands to run checks on local machine

bash .utils/terraform_run_all.sh init local
pre-commit run -a

gunzip
gunzip previously approved these changes Nov 6, 2023
Copy link

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, far better!

@Krusty93 Krusty93 marked this pull request as ready for review November 6, 2023 11:41
@Krusty93 Krusty93 requested a review from a team as a code owner November 6, 2023 11:41
@Krusty93 Krusty93 changed the title Improve GitHub Federated Identity module documentation docs: Improve GitHub Federated Identity module documentation Nov 6, 2023
@Krusty93 Krusty93 force-pushed the github-identity-docs branch from 76fbc6c to df917da Compare November 8, 2023 09:24
@Krusty93 Krusty93 merged commit b5836e6 into main Nov 20, 2023
3 checks passed
@Krusty93 Krusty93 deleted the github-identity-docs branch November 20, 2023 11:11
Copy link

🎉 This PR is included in version 7.27.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants