feat(app_gateway): Allow to attach WAF policy at gateway level #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Allow to attach WAF policy at gateway level and not only on listener level.
Motivation and context
Using WAF Config on the Gateway instead of dedicated WAF Policy attached to the Gateway is legacy and it's not advised on new configurations: https://learn.microsoft.com/en-us/azure/web-application-firewall/ag/best-practices#use-waf-policies
Type of changes
Does this introduce a breaking change?
Other information
Run checks
Useful commands to run checks on local machine
bash .utils/terraform_run_all.sh init local pre-commit run -a