feat: [PAYMCLOUD-198] Emit KSM V1 metrics on opencost module #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration to disable KSM V1 metrics while enabling KSM V1-only metrics for greater flexibility. This ensures compatibility with specific monitoring setups and cleaner metric management.
The change updates the Helm chart value for enabling the serviceMonitor by using the correct key. Additionally, the default project variable is modified from "cstar" to "pagopa" to reflect the updated project naming convention.
Switch the repository to the official OpenCost Helm chart and upgrade the version to 1.43.0. This change aligns with the latest updates and ensures compatibility with the OpenCost chart source.
Replaced the Prometheus OpenCost Exporter chart with the OpenCost chart in the Kubernetes configuration. This ensures alignment with the updated repository and the correct Helm chart for the deployment. Chart version remains configurable as needed.
Added the `opencost.defaultClusterId` parameter to Helm chart values, assigning it the AKS cluster name. This ensures proper identification of the cluster within OpenCost for accurate cost reporting.
Updated the configuration to disable the OpenCost UI and set `opencost.metrics.kubeStateMetrics.emitKsmV1MetricsOnly` to false. These changes aim to optimize performance and align with the updated usage requirements.
Removed an unintended trailing tab in the "emitKsmV1MetricsOnly" name. This ensures the configuration is correctly parsed and functions as expected.
Revert the OpenCost Helm chart version from 1.43.0 to 1.40.0. This change addresses compatibility issues or potential regressions introduced in the newer version.
Updated the Helm chart version from 1.40.0 to 1.43.0 to include the latest features, improvements, and bug fixes provided by OpenCost. This ensures the deployment stays up-to-date and aligns with best practices.
Updated the kubeStateMetrics setting to emit KSM v1 metrics by setting the value to "true". This ensures compatibility with systems relying on v1 metric outputs.
Replaced hardcoded Helm chart version with a configurable variable `opencost_helm_chart_version`. This improves flexibility and allows easier updates to the Helm chart version without modifying the main Terraform code. Added a default value for the variable in `99_variables.tf`.
|
🎉 This PR is included in version 8.71.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
List of changes
opencost_helm_chart_version.99_variables.tf.Motivation and context
This change was made to enhance flexibility in managing the Helm chart version for Opencost deployments. By introducing a configurable variable, it becomes easier to update the version without the need to modify the main Terraform code.
Type of changes
Does this introduce a breaking change?
Other information
No additional information provided.
Run checks
Useful commands to run checks on a local machine
bash .utils/terraform_run_all.sh init local pre-commit run -a