Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore removed workspace folders in setup-symlinks helper #530

Merged

Conversation

c0d1ngm0nk3y
Copy link
Contributor

Summary

It contains 2 fixes:

  • The symlinks for workspaces created by setup-symlink had an invalid target.
  • If a workspace does not exist, the helper failed because the symlink could not be read.

Use Cases

In case you do not want your final image to contain a workspace and delete it after build, the helper setup-symlinks would fail. Now, instead of failing, this symlink is just not created.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner August 15, 2023 11:12
@c0d1ngm0nk3y c0d1ngm0nk3y force-pushed the ignore-removed-workspaces branch from 388f364 to 7021680 Compare August 21, 2023 05:57
@thitch97
Copy link
Contributor

thitch97 commented Oct 5, 2023

Hi @c0d1ngm0nk3y, we've done some work that's now on main to fix the tests in this PR. If you could rebase this branch w those changes I'd be happy to get it merged.

@pbusko pbusko force-pushed the ignore-removed-workspaces branch from 7021680 to 7b23d3f Compare October 6, 2023 08:01
@pbusko
Copy link
Contributor

pbusko commented Oct 6, 2023

Hi @c0d1ngm0nk3y, we've done some work that's now on main to fix the tests in this PR. If you could rebase this branch w those changes I'd be happy to get it merged.

The PR has been rebased

@c0d1ngm0nk3y c0d1ngm0nk3y added the semver:patch A change requiring a patch version bump label Oct 6, 2023
@pbusko pbusko force-pushed the ignore-removed-workspaces branch from 7b23d3f to 5420c8e Compare October 10, 2023 06:59
@thitch97 thitch97 enabled auto-merge (rebase) October 11, 2023 19:03
@thitch97 thitch97 merged commit 2106142 into paketo-buildpacks:main Oct 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants