Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ubi-buildpackless-base builder on integration tests #579

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Adding ubi-buildpackless-base builder on integration tests #579

merged 5 commits into from
Feb 12, 2024

Conversation

pacostas
Copy link
Contributor

Merge after

Summary

This PR, tests npm-install against ubi buildpackless base builder in conjuction with ubi nodejs extention .

  • A new integration test has been added that tests the installation of Node.js addons (native modules)

Use Cases

Ensures that ubi-nodejs-extension and UBI images, cooperate with npm-install.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas force-pushed the ubi-buildpackless-builder-integration-tests branch 3 times, most recently from 57a19fc to 8c46023 Compare November 23, 2023 17:03
@pacostas pacostas marked this pull request as ready for review November 23, 2023 17:03
@pacostas pacostas requested a review from a team as a code owner November 23, 2023 17:03
@mhdawson
Copy link
Member

mhdawson commented Dec 1, 2023

@pacostas I think we can probably remove a bunch of the files under the node-addon-api directory under node_modules for the native test. I know the ones you have are all installed but I think the files like the .md files are definitely not necessary for the test and it's probably better not to add them to the repo here. I would remove all of the non-functional files under the node-addon-api directory as that will reduce the number of new files being added significantly.

@pacostas pacostas force-pushed the ubi-buildpackless-builder-integration-tests branch from 8c46023 to d084771 Compare December 4, 2023 13:10
@pacostas
Copy link
Contributor Author

pacostas commented Dec 4, 2023 •
edited
Loading

Removed unnecessary files and also squashed the commits

mhdawson
mhdawson reviewed Dec 4, 2023
View reviewed changes
integration/init_test.go Outdated Show resolved Hide resolved
@pacostas pacostas force-pushed the ubi-buildpackless-builder-integration-tests branch from d084771 to ddfc490 Compare December 5, 2023 10:27
mhdawson
mhdawson approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas
adding ubi-buildpacleks-builder and ubi-nodejs-extension on integrati…
e75a4e9 
…on tests

adding ubi-buildpackless-builder on empty node modules integration tests

adding ubi-buildpackless-builder on logging integration tests

adding ubi-buildpackless-builder on no node modules integration tests

adding ubi-buildpackless-base on npmrc integration tests

adding ubi-buildpackless-base on package lock mismatch integration tests

adding ubi-buildpackless-base on pre post scricpt integration tests

adding ubi-buildpacklesss on project path integration tests

adding ubi-buildpackless on restart integration tests

adding ubi-buildpackless-bse on unmet dependencies integration tests

adding ubi-buildpackless-builder on versioning integration tests

adding ubi-buildpackless-builder on workspaces integration tests

adding ubi-buildpackless-builder on simple app integration tests

adding ubi-buildpackless-base on vendored and vendored with binaries integration tests

adding a test for testing native modules installation during npm rebuild

adding ubi-buildpackless-base on caching integration tests

removing unused .md and .yml files
@pacostas pacostas force-pushed the ubi-buildpackless-builder-integration-tests branch from ddfc490 to e75a4e9 Compare December 13, 2023 10:23
@pacostas
Copy link
Contributor Author

rebased.

@thitch97 thitch97 added the semver:minor A change requiring a minor version bump label Jan 16, 2024
thitch97
thitch97 previously approved these changes Jan 16, 2024
View reviewed changes
@thitch97 thitch97 enabled auto-merge (rebase) January 16, 2024 21:35
@pacostas
Copy link
Contributor Author

@thitch97 I see that on ubi-nodejs-extension the latest release is on November 22 and the PR which is prerequisite for the tests to pass, merged on Dec 6. Can you cut a new release on ubi-nodejs-extension

@pacostas
Copy link
Contributor Author

pacostas commented Feb 1, 2024

@thitch97 Thanks for the new release, can you re-run the tests, probably everything should be working fine.

auto-merge was automatically disabled February 12, 2024 11:15

Head branch was pushed to by a user without write access

@thitch97 thitch97 merged commit db8a543 into paketo-buildpacks:main Feb 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@thitch97 thitch97 thitch97 approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@TisVictress TisVictress Awaiting requested review from TisVictress TisVictress is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacostas @mhdawson @thitch97