Add features to choose crypto backend #226
Open
+37
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Currently the default crypto backend is aws-lc-rs. This backend is not cross compilable from linux -> mac (issue) and the maintainers are not planning to implement support for this. We need conjure-runtime to be cross compilable because we are building a CLI app that runs on a variety of different platforms.
After this PR
This PR adds the features
ring
andaws-lc-rs
(default) which let you choose the CryptoProvider.ring
is cross compilable.==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?