Adjust hosting provider drupal/php settings include order #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the settings.php file to reverse the include order of the hosting provider boilerplate settings and project-specific settings.
Context from slack conversation:
Notes on Hosting Platform recommendations
From Byron:
Acquia: https://docs.acquia.com/cloud-platform/manage/code/require-line/
It seems like that aligns with including overrides after the settings files provided by each platform.
And, there's this for Pantheon which doesn't say anything about the order, just that it should always be included:
https://github.com/pantheon-systems/drops-8/blob/default/sites/default/settings.php#L8-L17
Pantheon docs: https://pantheon.io/docs/guides/php/settings-php#drupal-9
From Jes:
Similar to Pantheon, Platform.sh mentions adding custom settings to their settings file (which needs to be included) but nothing about the order: https://docs.platform.sh/guides/drupal9/deploy/customize.html#settingsphp
Testing instructions
Jes can validate that making this change in the DHS project codebases fixed the memcache setup. Prior to this change, Drupal was reporting memcache versions and no errors but New Relic was not showing any memcache resourcing being used.
phing install migrate
Open questions
Delete this section if there are no open questions.
Remaining tasks
Delete this section if there are no remaining tasks.