Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 11 #159

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Drupal 11 #159

wants to merge 13 commits into from

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Aug 16, 2024

User story: DEV-67: Update drupal-skeleton to Drupal 11

Description

Requires #156 and palantirnet/the-build#236

Testing instructions

  • composer create-project palantirnet/drupal-skeleton example dev-drupal11 --no-interaction --no-install
  • composer require --dev palantirnet/the-build:dev-drupal11
  • Continue with the drupal-skeleton getting started instructions in the readme, starting with step 2.

Open questions

Delete this section if there are no open questions.

  • What questions are blocking this work?

Remaining tasks

Delete this section if there are no remaining tasks.

  • Update the README
  • Todo: Once Workbench and Workbench Tabs have Drupal 11 compatibility, add them back.

@byrond byrond changed the title Update Composer dependencies for Drupal 11 Drupal 11 Aug 16, 2024
},
"require-dev": {
"behat/behat": "^3.12",
"behat/mink-goutte-driver": "^2.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like we don't need this anymore. Is this correct?
https://packagist.org/packages/behat/mink-goutte-driver

Drupal already has https://packagist.org/packages/behat/mink-browserkit-driver as a requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Maybe there's more to do here:

In GoutteFactory.php line 66:

Install MinkGoutteDriver in order to use goutte driver.
https://circleci.com/gh/palantirnet/drupal-skeleton/708

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by updating palantirnet/the-build@02cd8ee

@becw
Copy link
Member

becw commented Aug 20, 2024

This is exciting...

I think we're going to need to update to Node 20 at least, if not Node 22.

@byrond
Copy link
Contributor Author

byrond commented Aug 23, 2024

Tests are now passing with the changes from #160. While an update to Node 20 or 22 and Yarn 4 would be prudent, it is no longer blocking the D11 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants