New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) follow up changes on the case management: discontinuity of case #520

Closed

its-kios09 wants to merge 23 commits into palladiumkenya:main from its-kios09:new-case-mgt

Collaborator

its-kios09 commented Dec 17, 2024

Requirements

This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
My work conforms to the OpenMRS 3.0 Styleguide.
I checked for feature overlap with existing widgets.

Summary

Screenshots

None.

Related Issue

None.

Other

None.

its-kios09 added 3 commits

December 16, 2024 21:42


          (refactor) updating the uuids

38ba77e


          (feat) added end relationship functionality

e926ff3


          (feat) added a ability to end relationship on case management

3b62701

its-kios09 requested review from donaldkibet and Omoshlawi

December 17, 2024 22:21

Contributor

ojwanganto commented Dec 18, 2024

Looks OK. Thanks so much.


          Merge branch 'main' into new-case-mgt

087818c

donaldkibet requested changes

View reviewed changes

packages/esm-patient-clinical-view-app/src/case-management/modal/end-date.component.tsx Outdated Show resolved Hide resolved

.../esm-patient-clinical-view-app/src/case-management/modal/case-management-modal.component.tsx Outdated Show resolved Hide resolved

.../esm-patient-clinical-view-app/src/case-management/modal/case-management-modal.component.tsx Outdated Show resolved Hide resolved

.../esm-patient-clinical-view-app/src/case-management/modal/case-management-modal.component.tsx Show resolved Hide resolved

...atient-clinical-view-app/src/case-management/table/case-management-list-active-component.tsx Show resolved Hide resolved

...ient-clinical-view-app/src/case-management/table/case-management-list-inactive-component.tsx Show resolved Hide resolved

its-kios09 and others added 5 commits

December 19, 2024 08:08


          Merge branch 'main' into new-case-mgt

c307d8c


          Merge branch 'main' into new-case-mgt

02936e8


          (refactor) updated PR per suggestion

84e2943


          (feat) updated translation

e48dfcf


          (feat) added the unit test

b0fe70f

its-kios09 enabled auto-merge (squash)

December 19, 2024 15:34

its-kios09 added 2 commits

January 7, 2025 21:24


          Merge branch 'main' into new-case-mgt

f01cd1c


          Merge branch 'main' into new-case-mgt

cc40214

its-kios09 requested a review from donaldkibet

January 9, 2025 12:59

Contributor

ojwanganto commented Jan 9, 2025

Please remove code that is not related to case management from the commit. A best practice is to always branch from master/main and not any branch when checking out a new branch. That way, you will not carry over work for unrelated branch

Collaborator Author

its-kios09 commented Jan 9, 2025

Please remove code that is not related to case management from the commit. A best practice is to always branch from master/main and not any branch when checking out a new branch. That way, you will not carry over work for unrelated branch

@ojwanganto, Thanks, seems when I was doing this work i didn't checkout to a new branch, let me do the clean up


          Revert commits 38ba77e and e926ff3: Undo changes from Dec 16 and Dec 17

6af8746

ojwanganto reviewed

View reviewed changes

packages/esm-morgue-app/src/config-schema.ts

@@ @@ -21,7 +9,7 @@ export const configSchema = { @@
                 morgueDepartmentServiceTypeUuid: {
                   _type: Type.String,
                   _description: ' UUID for morgue department service type',
-                  _default: 'd7bd4cc0-90b1-4f22-90f2-ab7fde936727',
+                  _default: '5b9e6cd1-f836-4144-91e4-401c58dd62af',

Contributor

ojwanganto Jan 10, 2025

These are related to morgue functions

ojwanganto reviewed

View reviewed changes

packages/esm-morgue-app/src/config-schema.ts

                 },
                 policeIDNumber: {
                   _type: Type.String,
                   _description: 'UUID for police id number concept',
-                  _default: '8d488d02-d1d8-41a5-8219-61f4fc5dbeb0',
+                  _default: '163084AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA',

Contributor

ojwanganto Jan 10, 2025

and this

ojwanganto reviewed

View reviewed changes

packages/esm-morgue-app/src/config-schema.ts

                 },
                 policeNameUuid: {
                   _type: Type.String,
                   _description: 'UUID for police name concept',
-                  _default: '6d58d9b5-6f84-4e77-941e-f5cc86d18a60',
+                  _default: 'd889f05b-0d9b-462f-ae8e-2e9be79fd954',

Contributor

ojwanganto Jan 10, 2025

and this

ojwanganto reviewed

View reviewed changes

packages/esm-morgue-app/src/config-schema.ts

@@ @@ -36,7 +24,7 @@ export const configSchema = { @@
                 tagNumberUuid: {
                   _type: Type.String,
                   _description: 'UUID for tag number concept',
-                  _default: '13ba9c45-c540-4f10-b915-fa3d7baeb3d1',
+                  _default: 'f2b35679-7ba9-4619-92cb-6872b0c6bf57',

Contributor

ojwanganto Jan 10, 2025

and this

ojwanganto reviewed

View reviewed changes

packages/esm-morgue-app/src/config-schema.ts

                 },
                 burialPermitNumberUuid: {
                   _type: Type.String,
                   _description: 'UUID for burial permit number concept',
-                  _default: '29ef3df3-9845-49b0-96f2-5fb6d6240039',
+                  _default: 'da524812-5600-4677-ba26-eb61eb925eef',

Contributor

ojwanganto Jan 10, 2025

and this

ojwanganto reviewed

View reviewed changes

packages/esm-morgue-app/src/config-schema.ts

@@ @@ -56,22 +44,22 @@ export const configSchema = { @@
                 obNumberUuid: {
                   _type: Type.String,
                   _description: 'UUID for ob number concept',
-                  _default: 'c756d06a-22a5-4b66-933e-3d44667b72a0',
+                  _default: '0dffecb3-2dc4-4d56-8cd4-56ba38579c69',

Contributor

ojwanganto Jan 10, 2025

and this

its-kios09 added 4 commits

January 10, 2025 12:36


          (refactor) updating the uuids

9e71a43


          (feat) added end relationship functionality

632b3f3


          (feat) added a ability to end relationship on case management

53a27f5


          (refactor) updated PR per suggestion

29e5d48

its-kios09 and others added 7 commits

January 10, 2025 12:36


          (feat) updated translation

8990d5a


          (feat) added the unit test

eb37f0a


          (refactor) updated the config schema uuids (palladiumkenya#535)

c5e2a06


          Revert commits 38ba77e and e926ff3: Undo changes from Dec 16 and Dec 17

86c22ca


          Revert "(feat) added end relationship functionality"

e576f5c

This reverts commit e926ff3.


          (fix) duplicate type

5f06452


          Merge branch 'new-case-mgt' of github.com:its-kios09/kenyaemr-esm-3.x…

6a65b2c

… into new-case-mgt

its-kios09 force-pushed the new-case-mgt branch from 284a4f0 to 6a65b2c Compare

January 10, 2025 11:32

Collaborator Author

its-kios09 commented Jan 10, 2025

@ojwanganto I tried to remove the files seems it is breaking most of the case management functionality I have created a reference PR for this, so, that I can close this

its-kios09 closed this

auto-merge was automatically disabled

January 10, 2025 12:51

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet