Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandoc-include (https://github.com/DCsunset/pandoc-include) #251

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

cjkoenig
Copy link
Contributor

@cjkoenig cjkoenig commented Nov 4, 2024

Add support for splitted documents and code files

…d support for splitted documents and code files
@tarleb tarleb requested a review from daamien November 4, 2024 16:07
@daamien
Copy link
Collaborator

daamien commented Nov 5, 2024

@tarleb I'm approving this with 2 minor comments:

  • We already include 2 Lua filters named include-code-files and include-files that serve the same purpose. However the DCSunset filter seems much more popular, so I agree it's useful but redundant addition.

  • I would be nice to add a basic test file for this filter. we can add it later though

@tarleb tarleb merged commit f306f6b into pandoc:main Nov 5, 2024
1 check passed
@tarleb
Copy link
Member

tarleb commented Nov 5, 2024

Thanks!

@cjkoenig
Copy link
Contributor Author

cjkoenig commented Nov 6, 2024

Thank you for adding this! (I was not aware about the existing lua-filters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants