Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permalink to respect baseURL #498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ananay-22
Copy link

Noticed that the theme would break when I deployed to GH Pages because it ignores the baseURL (which is impossible to avoid with GH Pages specifically, and does require a nice bit of configuration if done after building with some nginx rule replacement etc).

This was being caused due to the fact that there was a use of 'RelPermaLink' instead of 'PermaLink' - adding in those changes in this PR

@panr
Copy link
Owner

panr commented Nov 23, 2024

Hey, two things:

  • can you provide some kind of comparison/preview for this (what if someone has set baseURL, what if hasn't, what about multiple domains)? This is a breaking change so we must be sure that it won't break anything. I remember that we already did some fixes regarding nginx few years ago...
  • are you sure that .PermaLink (camel case) is working? Because I think it should be .Permalink...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants