style: code cleanup

app/models/user.rb

@@ -6,8 +6,8 @@ class User < ApplicationRecord
   include PublicActivity::Model
   tracked owner: ->(controller, model) { controller && controller.current_user }
 
-  validates_presence_of :email
-  validates_format_of :email, with: URI::MailTo::EMAIL_REGEXP
+  validates :email, presence: true
+  validates :email, format: { with: URI::MailTo::EMAIL_REGEXP }
 
   enum role: [:user, :vip, :admin]
   after_initialize :set_default_role, :if => :new_record?

config/initializers/devise.rb

@@ -304,7 +304,7 @@
       host: Rails.application.credentials.dig(:oidc, :server_host),
       identifier: Rails.application.credentials.dig(:oidc, :client_id),
       secret: Rails.application.credentials.dig(:oidc, :secret_key),
-      redirect_uri: "https://#{Rails.application.secrets.domain_name}/users/auth/openid_connect/callback",
+      redirect_uri: "https://#{Rails.application.secrets.domain_name}/users/auth/openid_connect/callback"
     }
   }
 

db/migrate/20170727132107_create_enclosures.rb

@@ -9,11 +9,11 @@ def change
       t.timestamps
     end
     add_column :composants, :enclosure_id, :integer
-    Modele.all.each do |modele|
+    Modele.all.find_each do |modele|
       enclosure = Enclosure.new(position:1)
       modele.enclosures = [enclosure]
       modele.save
-      Composant.where(:modele_id => modele.id).all.each do |composant|
+      Composant.where(:modele_id => modele.id).all.find_each do |composant|
         composant.enclosure_id = enclosure.id
         composant.save
       end

db/migrate/20170803155630_init_cables_from_current_ports.rb

@@ -2,7 +2,7 @@
 
 class InitCablesFromCurrentPorts < ActiveRecord::Migration[5.0]
   def up
-    Port.all.each do |port|
+    Port.all.find_each do |port|
       cable = Cable.create(name: port.cablename, color: port.color)
       Connection.create(port: port, cable: cable)
     end

db/migrate/20180110152701_add_attributes_to_servers.rb

@@ -42,7 +42,7 @@ def init_pdus_for_every_frames
                                         port_type: port_type)
     puts "ERROR: #{card_type}" unless card_type.valid?
 
-    Frame.all.each do |frame|
+    Frame.all.find_each do |frame|
       ['A','B'].each do |line_name|
         pdu_name = "PDU_#{frame}_#{line_name}"
         pdu = Server.create(frame: frame,

lib/tasks/fix_duplicated_slots.rake

@@ -9,7 +9,7 @@ namespace :duplicated_slots do
   task :fix => :environment do
 
     Modele.includes(:enclosures => :composants)
-          .each do |modele|
+          .find_each do |modele|
 
       servers = []
       modele.enclosures.each do |enclosure|

lib/tasks/init_pdus.rake

@@ -7,7 +7,7 @@ namespace :init_pdus do
 
     # TODO: Refactor if we want to use it
     #
-    Port.where("cablename ~ 'L....'").each do |port|
+    Port.where("cablename ~ 'L....'").find_each do |port|
       puts "Cable #{port.cablename}"
       line = port.cablename[2]
       group = port.cablename[1]

spec/controllers/users/omniauth_callbacks_controller_spec.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe Users::OmniauthCallbacksController, type: :controller do
   describe '#openid_connect' do
-
-    before {
+    before do
       @user = User.find_or_create_by(email: '[email protected]')
       puts @user.inspect
-    }
+    end
 
     it 'creates a new user with valid authentication' do
       request.env['devise.mapping'] = Devise.mappings[:user]
@@ -24,9 +25,9 @@
       request.env['devise.mapping'] = Devise.mappings[:user]
       request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:openid_connect_unknown_user]
 
-      expect {
+      expect do
         get :openid_connect
-      }.not_to change(User, :count)
+      end.not_to change(User, :count)
 
       expect(controller.current_user).to be_nil
     end

spec/support/omniauth.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 OmniAuth.config.test_mode = true
 
 OmniAuth.config.mock_auth[:openid_connect] = OmniAuth::AuthHash.new(
   provider: :openid_connect,
   uid: 'user_unique_id',
   info: {
     email: '[email protected]',
-    name: 'John Doe',
+    name: 'John Doe'
     # Add other user information as needed for your tests
   },
   credentials: {
     token: 'valid_access_token',
-    expires_at: Time.now + 1.hour
+    expires_at: Time.zone.now + 1.hour
   }
 )
 
@@ -21,10 +23,10 @@
   uid: 'user_unique_id',
   info: {
     email: '[email protected]',
-    name: 'Unknown User',
+    name: 'Unknown User'
   },
   credentials: {
     token: 'valid_access_token',
-    expires_at: Time.now + 1.hour
+    expires_at: Time.zone.now + 1.hour
   }
 )

test/services/omniauth_dynamic_full_host_test.rb

@@ -19,7 +19,7 @@ def setup
 
   def test_full_host_without_specific_origin
     @strategy.call!(make_env('/whatever', 'rack.url_scheme' => 'http', 'SERVER_NAME' => 'facebook.lame',
-                             'QUERY_STRING' => 'code=asofibasf|asoidnasd', 'SCRIPT_NAME' => '', 'SERVER_PORT' => 80))
+                                          'QUERY_STRING' => 'code=asofibasf|asoidnasd', 'SCRIPT_NAME' => '', 'SERVER_PORT' => 80))
     assert @strategy.full_host, 'http://example.com'
   end