feat(backfill): add #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shekhirin
commented
Jul 18, 2024
•
shekhirin
commented
shekhirin
force-pushed
the
alexey/backfill
branch
from
4ef34b4 to
897fad9
Compare
mattsse
requested changes
Jul 19, 2024
backfill/src/main.rs
Outdated
Comment on lines
47
to
48
| Some(range) = self.backfill_rx.recv() => { | ||
| let _ = self.backfill(range).await.inspect_err(|err| error!(%err, "Backfill error occurred")); |
There was a problem hiding this comment.
this will effectively wait until the range is done, and could starve notification processing, we should just spawn this, ideally we also spawn and use some semaphor as guard so we limit the concurrent backfill requests
mattsse
requested changes
Jul 22, 2024
Comment on lines
+107
to
+111
| let permit = self | ||
| .backfill_semaphore | ||
| .clone() | ||
| .try_acquire_owned() | ||
| .map_err(|err| eyre::eyre!("concurrent backfills limit reached: {err:?}"))?; |
There was a problem hiding this comment.
this needs to be moved into spawn and await acquire
There was a problem hiding this comment.
it will just block the RPC request, right? I explicitly return an error if we ran out of permits.
mattsse
approved these changes
Jul 22, 2024
|
we'll also want a stop backfill command i think by job id, and returning a job id on creation of a backfill job |
yep, in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.