pr feedback

packages/core/core/src/Parcel.js

@@ -48,7 +48,6 @@ export default class Parcel {
   #requestTracker /*: RequestTracker*/;
   #config /*: ParcelConfig*/;
   #farm /*: WorkerFarm*/;
-  #isInitialBuild /*: boolean*/ = true;
   #initialized /*: boolean*/ = false;
   #disposable /*: Disposable */;
   #initialOptions /*: InitialParcelOptions*/;
@@ -300,7 +299,7 @@ export default class Parcel {
           options,
         ),
         buildTime: Date.now() - startTime,
-        requestBundle: async bundle => {
+        requestBundle: async (bundle) => {
           let bundleNode = bundleGraph._graph.getNodeByContentKey(bundle.id);
           invariant(bundleNode?.type === 'bundle', 'Bundle does not exist');
 
@@ -378,18 +377,15 @@ export default class Parcel {
         }
 
         let isInvalid = this.#requestTracker.respondToFSEvents(
-          events.map(e => ({
+          events.map((e) => ({
             type: e.type,
             path: toProjectPath(resolvedOptions.projectRoot, e.path),
           })),
-          {isInitialBuild: this.#isInitialBuild},
         );
         if (isInvalid && this.#watchQueue.getNumWaiting() === 0) {
           if (this.#watchAbortController) {
             this.#watchAbortController.abort();
           }
-
-          this.#isInitialBuild = false;
           this.#watchQueue.add(() => this._startNextBuild());
           this.#watchQueue.run();
         }

packages/core/core/src/RequestTracker.js

@@ -113,12 +113,12 @@ type RequestGraphEdgeType =
   | 'dirname';
 
 export type RunAPI = {|
-  invalidateOnFileCreate: InternalFileCreateInvalidation => void,
-  invalidateOnFileDelete: ProjectPath => void,
-  invalidateOnFileUpdate: ProjectPath => void,
+  invalidateOnFileCreate: (InternalFileCreateInvalidation) => void,
+  invalidateOnFileDelete: (ProjectPath) => void,
+  invalidateOnFileUpdate: (ProjectPath) => void,
   invalidateOnStartup: () => void,
-  invalidateOnEnvChange: string => void,
-  invalidateOnOptionChange: string => void,
+  invalidateOnEnvChange: (string) => void,
+  invalidateOnOptionChange: (string) => void,
   getInvalidations(): Array<RequestInvalidation>,
   storeResult: (result: mixed, cacheKey?: string) => void,
   getRequestResult<T>(contentKey: ContentKey): Async<?T>,
@@ -469,7 +469,7 @@ export class RequestGraph extends ContentGraph<
       'invalidated_by_update',
     );
     return invalidations
-      .map(nodeId => {
+      .map((nodeId) => {
         let node = nullthrows(this.getNode(nodeId));
         switch (node.type) {
           case 'file':
@@ -490,7 +490,7 @@ export class RequestGraph extends ContentGraph<
 
     let subRequests = this.getNodeIdsConnectedFrom(requestNodeId, 'subrequest');
 
-    return subRequests.map(nodeId => {
+    return subRequests.map((nodeId) => {
       let node = nullthrows(this.getNode(nodeId));
       invariant(node.type === 'request');
       return node.value;
@@ -548,7 +548,7 @@ export class RequestGraph extends ContentGraph<
 
   respondToFSEvents(
     events: Array<{|path: ProjectPath, type: EventType|}>,
-    opts: {|isInitialBuild: boolean|},
+    opts?: {|isInitialBuild: boolean|},
   ): boolean {
     let didInvalidate = false;
     for (let {path: _filePath, type} of events) {
@@ -558,7 +558,7 @@ export class RequestGraph extends ContentGraph<
       // If we see a 'create' event for the project root itself,
       // this means the project root was moved and we need to
       // re-run all requests.
-      if (opts.isInitialBuild && type === 'create' && filePath === '') {
+      if (opts?.isInitialBuild && type === 'create' && filePath === '') {
         for (let [id, node] of this.nodes) {
           if (node.type === 'request') {
             this.invalidNodeIds.add(id);
@@ -600,7 +600,7 @@ export class RequestGraph extends ContentGraph<
           let above = this.getNodeIdsConnectedTo(
             fileNameNodeId,
             'invalidated_by_create_above',
-          ).map(nodeId => {
+          ).map((nodeId) => {
             let node = nullthrows(this.getNode(nodeId));
             invariant(node.type === 'file');
             return node;
@@ -653,6 +653,7 @@ export default class RequestTracker {
   farm: WorkerFarm;
   options: ParcelOptions;
   signal: ?AbortSignal;
+  isInitialBuild: boolean;
 
   constructor({
     graph,
@@ -760,9 +761,8 @@ export default class RequestTracker {
 
   respondToFSEvents(
     events: Array<{|path: ProjectPath, type: EventType|}>,
-    opts: {|isInitialBuild: boolean|},
   ): boolean {
-    return this.graph.respondToFSEvents(events, opts);
+    return this.graph.respondToFSEvents(events);
   }
 
   hasInvalidRequests(): boolean {
@@ -858,16 +858,16 @@ export default class RequestTracker {
   ): {|api: RunAPI, subRequestContentKeys: Set<ContentKey>|} {
     let subRequestContentKeys = new Set<ContentKey>();
     let api: RunAPI = {
-      invalidateOnFileCreate: input =>
+      invalidateOnFileCreate: (input) =>
         this.graph.invalidateOnFileCreate(requestId, input),
-      invalidateOnFileDelete: filePath =>
+      invalidateOnFileDelete: (filePath) =>
         this.graph.invalidateOnFileDelete(requestId, filePath),
-      invalidateOnFileUpdate: filePath =>
+      invalidateOnFileUpdate: (filePath) =>
         this.graph.invalidateOnFileUpdate(requestId, filePath),
       invalidateOnStartup: () => this.graph.invalidateOnStartup(requestId),
-      invalidateOnEnvChange: env =>
+      invalidateOnEnvChange: (env) =>
         this.graph.invalidateOnEnvChange(requestId, env, this.options.env[env]),
-      invalidateOnOptionChange: option =>
+      invalidateOnOptionChange: (option) =>
         this.graph.invalidateOnOptionChange(
           requestId,
           option,
@@ -883,7 +883,7 @@ export default class RequestTracker {
         return this.getRequestResult<T>(contentKey, ifMatch);
       },
       getRequestResult: <T>(id): Async<?T> => this.getRequestResult<T>(id),
-      canSkipSubrequest: contentKey => {
+      canSkipSubrequest: (contentKey) => {
         if (
           this.graph.hasContentKey(contentKey) &&
           this.hasValidResult(this.graph.getNodeIdByContentKey(contentKey))
@@ -958,7 +958,9 @@ export default class RequestTracker {
 }
 
 export function getWatcherOptions(options: ParcelOptions): WatcherOptions {
-  let vcsDirs = ['.git', '.hg'].map(dir => path.join(options.projectRoot, dir));
+  let vcsDirs = ['.git', '.hg'].map((dir) =>
+    path.join(options.projectRoot, dir),
+  );
   let ignore = [options.cacheDir, ...vcsDirs];
   return {ignore};
 }
@@ -985,11 +987,11 @@ async function loadRequestGraph(options): Async<RequestGraph> {
     requestGraph.invalidateEnvNodes(options.env);
     requestGraph.invalidateOptionNodes(options);
     requestGraph.respondToFSEvents(
-      events.map(e => ({
+      events.map((e) => ({
         type: e.type,
         path: toProjectPath(options.projectRoot, e.path),
       })),
-      {isInitialBuild: false},
+      {isInitialBuild: true},
     );
 
     return requestGraph;