[node] Add Optional dnsPolicy Configuration #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakhtin
reviewed
Nov 23, 2023
charts/node/values.yaml
Outdated
| @@ -674,6 +674,10 @@ jaegerAgent: | |||
| # -- Annotations to add to the Pod | |||
| podAnnotations: {} | |||
|
|
|||
| # dnsPolicy can be set to 'ClusterFirst', 'Default', 'None', or 'ClusterFirstWithHostNet' | |||
There was a problem hiding this comment.
We're using a specific format for annotating values. Check out the rest of the file. All the comments start with # --. This is a special syntax used by helm-docs tool that we use for autogenerating README file based on the annotated values.
Make sure to render an updated README.md by running helm-docs locally. Check out our contributing guide for the details.
There was a problem hiding this comment.
My bad, already pushed a commit to fix it.
bakhtin
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In certain Kubernetes deployments, the default dnsPolicy of ClusterFirst can cause issues with the resolution of external domain names. This problem was particularly evident with telemetry endpoints, where nodes were unable to establish connections due to DNS resolution failures, defaulting to Kubernetes' internal DNS service (e.g., *.svc.cluster.local).
Proposed solution
This pull request introduces an optional configuration option dnsPolicy for nodes in the Helm charts. This change aims to address an issue where nodes running inside Kubernetes environments fail to properly resolve external URLs, specifically telemetry URLs, due to the default dnsPolicy setting.