Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the P2P port even if the pod is not ready #342

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

BulatSaif
Copy link
Contributor

When enableSidecarReadinessProbe is set to true, the pod will not be marked as ready until it has enough peers and is synced. However, we need to open the P2P port for incoming connections to have more peers and sync faster.

@BulatSaif BulatSaif self-assigned this May 14, 2024
Copy link
Contributor

@PierreBesson PierreBesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but would prefer to rewrite NotReady to Unready.

@BulatSaif BulatSaif merged commit e0d4d37 into main May 14, 2024
3 checks passed
@BulatSaif BulatSaif deleted the bs/fix-p2p-port branch May 14, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants