Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes createFile explicit non-resumable uploads by default. Useful to… #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tindice
Copy link

@tindice tindice commented Feb 4, 2017

… fastest small files uploads.

@codecov-io
Copy link

codecov-io commented Feb 4, 2017

Codecov Report

Merging #17 into master will increase coverage by 0.55%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   51.38%   51.94%   +0.55%     
==========================================
  Files           1        1              
  Lines          72       77       +5     
  Branches       12       13       +1     
==========================================
+ Hits           37       40       +3     
- Misses         35       37       +2
Impacted Files Coverage Δ
index.js 51.94% <66.66%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70213b...bb15dfc. Read the comment docs.

@tindice
Copy link
Author

tindice commented Feb 4, 2017

I guess it should be better to expose the option, but I really needed the change to prevent my setup to become unresponsive during high loads (file migration from legacy files)

@flovilmart
Copy link
Contributor

Could you expose the option in the adapter constructor?

@tindice
Copy link
Author

tindice commented Feb 13, 2017

Hi @flovilmart

I did the changes, what do you think?
Ultimately the ability of being resumable or not can be chosen per file, that's why I included it on createFile, but it will default to whatever is used on the constructor if not specified.

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants