Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @aantron/repromise to reason-promise #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade @aantron/repromise to reason-promise #1

wants to merge 1 commit into from

Conversation

aantron
Copy link

@aantron aantron commented Feb 3, 2020

Repromise became reason-promise in 1.0.0. The API was renamed (e.g., Repromise.wait is now Promise.get), rearranged to prefer -> instead of |>, and helpers were added for Result and Option, as well as some miscellaneous ones. In particular, the addition of mapOk, tapOk, flatMapOk, mapSome, and Promise.Js.toResult has made Promises.re redundant, so I've removed it.

The bundle size of reason-promise was reduced to 1K. See the changelog here; there are also two subsequent bugfix releases.

@pascalw
Copy link
Owner

pascalw commented Feb 9, 2020

Hey @aantron thank you for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants