Use a version constant instead of parsing gemspec

[DerekStride]

Issue

When deploying an application to a container that doesn't contain git the passage client throws an error when trying to add the version number to the header.

passage-ruby/lib/passageidentity/client.rb

Lines 99 to 101 in 3bd08db

	gemspec = File.join(__dir__, "../../passageidentity.gemspec")
	spec = Gem::Specification.load(gemspec)
	headers = { "Passage-Version" => "passage-ruby #{spec.version}" }

This line calls out to the shell to run the git ls-files command:

passage-ruby/passageidentity.gemspec

Line 22 in 3bd08db

`git ls-files -z`.split("\x0").reject do |f|

Error

(ruby) spec = Gem::Specification.load(gemspec)
Invalid gemspec in [/app/vendor/bundle/ruby/3.2.0/gems/passageidentity-0.2.3/lib/passageidentity/../../passageidentity.gemspec]:
No such file or directory - git

Solution

This PR changes this project to use the more standard RubyGems approach to have a VERSION constant defined and loaded in the gemspec. I've tested my fork on my application and it seems to work as expected.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[DerekStride]

@vanessa-passage Would I be able to get a review on this PR? Without it it's hard to deploy to a containerized environment.

[DerekStride]

The test failures seem to be related to my fork not including the expected environment variables:

env:
  API_KEY: 
  APP_ID: 
  PSG_JWT: 
  TEST_USER_ID: 

[vanessa-passage]

@DerekStride looks good!
Tested locally, all tests are passing.

[vanessa-passage]

Sorry for the request after the approval. Can you revert the version bump?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[DerekStride]

All good, I've updated the PR, should be good to go. Let me know if there's anything else I can update.

[vanessa-passage]

👍 LGTM