Skip to content

Commit

Permalink
Release v1.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
pavlobu committed Jan 18, 2021
1 parent b8f6d57 commit ad20745
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 7 deletions.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,15 @@ create two separate projects in SonarCube panel.
First project for host app, and second project for client viewer app.
TODO: add how to get started with local SonarCube for Deskreen in details.

## Note on versioning:

- All versions git tags should start with `v` ex. `v1.0.0`
- Before making a new release with `git push <version-tagname>` set version
to `<version-tagname>` ! without `v` in the beginning! (ex. `1.0.0` -- not start with `v`) in these three files:
- `package.json` -- in `version` key ex. `1.0.0`
- `app/package.json` -- in `version` key ex. `1.0.0`
- `app/package-lock.json` -- in `version` key ex. `1.0.0`

## Maintainer

- [Pavlo (Paul) Buidenkov](https://www.linkedin.com/in/pavlobu)
Expand Down
2 changes: 1 addition & 1 deletion app/components/SettingsOverlay/SettingsOverlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ export default function SettingsOverlay(props: SettingsOverlayProps) {
onClick={(e) => {
e.preventDefault();
shell.openExternal(
'https://github.com/pavlobu/deskreen/releases/'
'https://github.com/pavlobu/deskreen/releases/latest'
);
}}
>
Expand Down
6 changes: 4 additions & 2 deletions app/main.dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,15 @@ export default class DeskreenApp {
const showNotification = () => {
const notification = {
title: 'Deskreen Update is Available!',
body: `Your current version is ${this.appVersion} Click to download new 1.0.1 updated version.`,
body: `Your current version is ${this.appVersion} Click to download new ${this.latestVersion} updated version.`,
};
const notificationInstance = new Notification(notification);
notificationInstance.show();
notificationInstance.on('click', (event) => {
event.preventDefault(); // prevent the browser from focusing the Notification's tab
shell.openExternal('https://github.com/pavlobu/deskreen/releases/');
shell.openExternal(
'https://github.com/pavlobu/deskreen/releases/latest'
);
});
};

Expand Down
2 changes: 1 addition & 1 deletion app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion app/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "deskreen",
"productName": "deskreen",
"version": "1.0.0-alfa-beta",
"version": "1.0.0",
"description": "Deskreen makes any device a second screen for your computer",
"main": "./main.prod.js",
"author": {
Expand Down
3 changes: 2 additions & 1 deletion app/utils/getNewVersionTag.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import axios from 'axios';

const githubApiRepoTagsUrl =
'https://api.github.com/repos/pavlobu/circleCInodeapp/tags';
'https://api.github.com/repos/pavlobu/deskreen/tags';

export default async function getNewVersionTag() {
let latestVersionTag = '';
Expand All @@ -18,6 +18,7 @@ export default async function getNewVersionTag() {
});

latestVersionTag = foundTag ? foundTag.name : '';
latestVersionTag = latestVersionTag.slice(1);

return latestVersionTag;
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "deskreen",
"productName": "Deskreen",
"version": "1.0.0-alfa-beta",
"version": "1.0.0",
"description": "Deskreen makes any device a second screen for your computer",
"scripts": {
"build": "yarn build-main && yarn build-renderer && yarn build-client",
Expand Down

0 comments on commit ad20745

Please sign in to comment.