-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform-independent #16
Comments
That all sounds amazing 👍 The |
Ok, I've done this. There's a problem though. I've already forked robrighter/nw-desktop-notifications and have unresolved PRs. Since this is a fork of the same project, it's awkward. I figured out how to manually create a second fork of the same repository (because you can't via GitHub itself) but there's no way to create a PR back to this repository via GitHub (even though I did set up the remotes correctly). I did try using pullr to do it from the command-line but it doesn't work because I've two-factor auth. turned on. The only way I can see around this is to add me as a collaborator to this project so I can commit directly onto a new branch and then create a PR from that branch to master. To see the summary of changes, see this PR I accidentally created within my fork. |
👍 @adam-lynch sorry for the delay, just added you as a collaborator. |
@pbojinov thanks. I'll try push the commits tomorrow. |
FYI, I'm going to create a PR like robrighter#7 where I'll switch grunt to gulp, remove the need for
.sh
file and use node-webkit-builder.The text was updated successfully, but these errors were encountered: