Switching everything to Gulp & renaming #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readme was missing the `cd src && bower i` step so I just decided to check the dependencies in to make things easier
Note: now outputs builds for linux 32 & 64 bit because why not?
|
Great work! @adam-lynch 👍 👍 👍 Its amazing how fast the build is now with gulp |
|
😄 Yeah, gulp is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started off just switching things to gulp as I said I would in #16, but then I went ahead and made a couple of other changes too. I normally would make separate PRs from separate branches but these other changes depend on the first PR anyway.
Other things include renaming "nw-desktop-notifications", etc. to "nodeifications" everywhere, checking in the bower dependencies and noting in the readme that nodewebkit >=0.9.2 is required.