Skip to content

Commit

Permalink
Release Keila 0.14.3
Browse files Browse the repository at this point in the history
Another attempt to fix STARTTLS issues: Only support TLSv1.2 since OTP isn't fully compliant with 1.3 yet
  • Loading branch information
wmnnd committed Apr 22, 2024
1 parent b2eeb4e commit 8c3166b
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## Unreleased

## Version 0.14.3

## Fixed
- Only support TLSv1.2 for STARTTLS SMTP Senders to avoid issues with
non-compliant TLSv1.3 implementation in OTP

## Version 0.14.2

## Improved
Expand Down
5 changes: 4 additions & 1 deletion config/runtime.exs
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ if config_env() == :prod do
if starttls? do
config
|> Keyword.put(:tls, :always)
|> Keyword.put(:tls_options, :tls_certificate_check.options(host))
|> Keyword.put(
:tls_options,
:tls_certificate_check.options(host) ++ [versions: [:"tlsv1.2"]]
)
else
config
end
Expand Down
2 changes: 1 addition & 1 deletion lib/keila/mailings/sender_adapters/smtp.ex
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ defmodule Keila.Mailings.SenderAdapters.SMTP do
opts
|> Keyword.put(:tls, :always)
|> Keyword.put(:tls_options, :tls_certificate_check.options(config.smtp_relay))
|> put_in([:tls_options, :versions], [:"tlsv1.2", :"tlsv1.3"])
|> put_in([:tls_options, :versions], [:"tlsv1.2"])

true ->
opts
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule Keila.MixProject do
def project do
[
app: :keila,
version: "0.14.2",
version: "0.14.3",
elixir: "~> 1.15",
elixirc_paths: elixirc_paths(Mix.env()),
compilers: [:phoenix] ++ Mix.compilers(),
Expand Down

0 comments on commit 8c3166b

Please sign in to comment.