Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get annotations by reg_paths list endpoint #247

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Dec 17, 2023

Added get endpoint that allows fetch annotations by providing a list of registry_paths

Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. I think that I am a little confused why we are importing two routers from the namespace router file, and
  2. I want to keep the "get projects by list of registry paths" functionality on the /projects endpoint.

pephub/main.py Outdated Show resolved Hide resolved
pephub/routers/api/v1/namespace.py Show resolved Hide resolved
pephub/routers/api/v1/namespace.py Outdated Show resolved Hide resolved
@nleroy917
Copy link
Member

nleroy917 commented Dec 18, 2023

I pulled the code and I see now why there are two routers. In also see why you added that endpoint.

New plan: We move the "get several projects based on a list of project_ids to a /projects endpoint. So, it would be:

GET /api/v1/projects?registry_paths=[...]

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0fca875
Status: ✅  Deploy successful!
Preview URL: https://2f52ee68.pephub.pages.dev
Branch Preview URL: https://reg-paths-list.pephub.pages.dev

View logs

@nleroy917 nleroy917 merged commit cb5b0ec into dev Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants