Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

328 models #355

Merged
merged 4 commits into from
Jul 15, 2024
Merged

328 models #355

merged 4 commits into from
Jul 15, 2024

Conversation

khoroshevskyi
Copy link
Member

No description provided.

@khoroshevskyi khoroshevskyi requested a review from nleroy917 July 15, 2024 19:48
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty ok -- are the response models on all endpoints?

@@ -67,9 +67,7 @@ async def get_namespace(

namespace: databio
"""
nspace = nspace.model_dump()
nspace["projects_endpoint"] = f"{str(request.url)[:-1]}/projects"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we using this for anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I am testing and can't find any issue

@khoroshevskyi khoroshevskyi merged commit 5e4b714 into dev Jul 15, 2024
1 check passed
@khoroshevskyi khoroshevskyi deleted the 328_models branch July 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants