Add/remove view UI #359
Merged
Add/remove view UI #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create view mutations
…e added if table currently has a filter, and modal is updated accordingly. adding a view also uses the value of sample_table_index from config if it is present, otherwise it uses "sample_name" by default.
nleroy917
reviewed
Jul 23, 2024
| @@ -3,9 +3,11 @@ import { OverlayTrigger, Tooltip } from 'react-bootstrap'; | |||
| import { useProjectPageView } from '../../hooks/stores/useProjectPageView'; | |||
| import { ViewSelector } from '../project/view-selector'; | |||
|
|
|||
| type PageView = 'samples' | 'subsamples' | 'config'; | |||
| type PageView = 'samples' | 'subsamples' | 'config' | 'help'; | |||
There was a problem hiding this comment.
Do we think we are going to remove this?
Comment on lines
+109
to
+119
| <div className={pageView === 'help' ? 'border-0 px-1 h-100 text-muted bg-white shadow-sm' : 'px-1 h-100'}> | ||
| <ViewButton | ||
| view="help" | ||
| setPageView={setPageView} | ||
| icon="bi bi-question-circle-fill me-2" | ||
| text="Help" | ||
| isDirty={false} | ||
| bold={pageView === 'help' ? ' fw-normal' : ' fw-light'} | ||
| color={pageView === 'help' ? ' text-dark' : ' text-muted'} | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
Do we think we will still keep this?
Comment on lines
+51
to
+56
| useEffect(() => { | ||
| if (projectConfigQuery.data?.config) { | ||
| const index = extractSampleTableIndex(projectConfigQuery.data.config); | ||
| setSampleTableIndex(index); | ||
| } | ||
| }, [projectConfigQuery.data]); |
There was a problem hiding this comment.
You might be able to get away without an effect here.
Just something like:
const sampleTableIndex = projectConfigQuery ? extractSampleTableIndex(projectConfigQuery.data.config) : 'sample_name';There was a problem hiding this comment.
I try to avoid useEffect at all costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding views from filtered sample tables works, but the view selector in projects has a bug as of a couple weeks ago and doesn't actually filter the handsontable. The views themselves are good though. You can create a view from dev_sam with a filtered sample table, then git checkout 83e7fe and choose the view you created to display the correctly filtered rows.