Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBM-1466 - Remove kingpin dependency from pbm cli #1077

Merged
merged 13 commits into from
Jan 15, 2025
Merged

PBM-1466 - Remove kingpin dependency from pbm cli #1077

merged 13 commits into from
Jan 15, 2025

Conversation

veceraj
Copy link
Collaborator

@veceraj veceraj commented Jan 7, 2025 •
edited
Loading

PR for https://perconadev.atlassian.net/browse/PBM-1466

The PR replaces the use of kingpin by Cobra and Viper.

@veceraj veceraj marked this pull request as ready for review January 9, 2025 07:51
@veceraj veceraj requested a review from boris-ilijic as a code owner January 9, 2025 07:51
boris-ilijic
boris-ilijic reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@boris-ilijic boris-ilijic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready to be merged, but there are few suggestions that I'd prefer to improve.

Also we should remove completely kingpin dependency from go.mod, so let's do it here or in new PR (better).

cmd/pbm/main.go Outdated Show resolved Hide resolved
cmd/pbm/main.go Outdated Show resolved Hide resolved
cmd/pbm/main.go Outdated Show resolved Hide resolved
cmd/pbm/main.go Outdated Show resolved Hide resolved
cmd/pbm/main.go Outdated Show resolved Hide resolved
cmd/pbm/main.go Outdated Show resolved Hide resolved
@veceraj
Copy link
Collaborator Author

veceraj commented Jan 13, 2025

Thanks, I like all the comments. Will update shortly.

@veceraj veceraj requested a review from boris-ilijic January 15, 2025 10:04
@veceraj veceraj merged commit 3dd80f5 into dev Jan 15, 2025
22 checks passed
@veceraj veceraj deleted the PBM-1466 branch January 15, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boris-ilijic boris-ilijic boris-ilijic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veceraj @boris-ilijic