Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PXB-3141 - fix folder permission on fifo get #1508

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix PXB-3141 - fix folder permission on fifo get #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storage/innobase/xtrabackup/src/ds_fifo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static ds_ctxt_t *fifo_init(const char *root) {
ds_ctxt_t *ctxt = new ds_ctxt_t;
char fullpath[FN_REFLEN];

if (my_mkdir(root, 0600, MYF(0)) < 0 && my_errno() != EEXIST &&
if (my_mkdir(root, 0777, MYF(0)) < 0 && my_errno() != EEXIST &&
my_errno() != EISDIR) {
char errbuf[MYSYS_STRERROR_SIZE];
my_error(EE_CANT_MKDIR, MYF(0), root, my_errno(),
Expand Down
2 changes: 1 addition & 1 deletion storage/innobase/xtrabackup/src/xbcloud/xbcloud.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,7 @@ bool xbcloud_download(Object_store *store, const std::string &container,
/* Create FIFO files if necessary */

if (opt_threads > 1) {
if (my_mkdir(opt_fifo_dir, 0600, MYF(0)) < 0 && my_errno() != EEXIST &&
if (my_mkdir(opt_fifo_dir, 0777, MYF(0)) < 0 && my_errno() != EEXIST &&
my_errno() != EISDIR) {
char errbuf[MYSYS_STRERROR_SIZE];
msg_ts("%s: Error creating dir: %s. (%d) %s\n", my_progname, opt_fifo_dir,
Expand Down
1 change: 1 addition & 0 deletions storage/innobase/xtrabackup/test/suites/xbcloud/fifo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ take_backup_fifo_xbcloud ${topdir}/stream "--parallel=4 --fifo-streams=3 --incre
record_db_state test

vlog "download & prepare"
rm -rf ${topdir}/stream
download_fifo_xbcloud ${topdir}/stream "--parallel=10 --fifo-streams=3 ${full_backup_name}" "-x -C ${topdir}/full --fifo-streams=3"
download_fifo_xbcloud ${topdir}/stream "--parallel=10 --fifo-streams=3 ${inc_backup_name}" "-x -C ${topdir}/inc1 --fifo-streams=3"
download_fifo_xbcloud ${topdir}/stream "--parallel=10 --fifo-streams=3 ${inc2_backup_name}" "-x -C ${topdir}/inc2 --fifo-streams=3"
Expand Down