Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xtrabackup.cc Linux native AIO option print #1510

Closed
wants to merge 1 commit into from

Conversation

wangbincmss
Copy link
Contributor

@wangbincmss wangbincmss commented Oct 24, 2023

when ./xtrabackup --innodb-use-native-aio=true
2023-10-24T18:20:58.174714+08:00 0 [Note] [MY-011825] [Xtrabackup] innodb_log_file_size = 2147483648
2023-10-24 18:20:58 1402668759925762023-10-24T18:20:58.174761+08:00 0 [Note] [MY-011825] [InnoDB] Using Linux native AIO
2023-10-24T18:20:58.174776+08:00 0 [Note] [MY-011825] [Xtrabackup] using O_DIRECT

the print message timestamp is confused
2023-10-24 18:20:58 1402668759925762023-10-24T18:20:58.174761+08:00 0 [Note] [MY-011825] [InnoDB] Using Linux native AIO

after change
2023-10-24T18:50:00.137254+08:00 0 [Note] [MY-011825] [Xtrabackup] innodb_log_file_size = 2147483648
2023-10-24T18:50:00.137286+08:00 0 [Note] [MY-011825] [InnoDB] Using Linux native AIO
2023-10-24T18:50:00.137314+08:00 0 [Note] [MY-011825] [Xtrabackup] using O_DIRECT
the timestamp is consistent format

 when ./xtrabackup    --innodb-use-native-aio=true
2023-10-24T18:20:58.174714+08:00 0 [Note] [MY-011825] [Xtrabackup] innodb_log_file_size = 2147483648
2023-10-24 18:20:58 1402668759925762023-10-24T18:20:58.174761+08:00 0 [Note] [MY-011825] [InnoDB] Using Linux native AIO
2023-10-24T18:20:58.174776+08:00 0 [Note] [MY-011825] [Xtrabackup] using O_DIRECT
the print message timestamp is confused
2023-10-24 18:20:58 1402668759925762023-10-24T18:20:58.174761+08:00 0 [Note] [MY-011825] [InnoDB] Using Linux native AIO

after change 
2023-10-24T18:50:00.137254+08:00 0 [Note] [MY-011825] [Xtrabackup] innodb_log_file_size = 2147483648
2023-10-24T18:50:00.137286+08:00 0 [Note] [MY-011825] [InnoDB] Using Linux native AIO
2023-10-24T18:50:00.137314+08:00 0 [Note] [MY-011825] [Xtrabackup] using O_DIRECT
the timestamp is consistent format
@wangbincmss
Copy link
Contributor Author

@altmannmarcelo please review

@altmannmarcelo altmannmarcelo self-requested a review October 24, 2023 16:10
@altmannmarcelo
Copy link
Contributor

altmannmarcelo commented Oct 25, 2023

@wangbincmss I am preparing the 8.0 and trunk branches to merge this fix. What is your real name so we can credit the fix to you in our Release Notes ?

@wangbincmss
Copy link
Contributor Author

@wangbincmss I am preparing the 8.0 and trunk branches to merge this fix. What is your real name so we can credit the fix to you in our Release Notes ?

real name is Bin Wang ,company is China Mobile

@altmannmarcelo
Copy link
Contributor

Thanks @wangbincmss for your contribution. Merged as part of #1513 and #1514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants