Fix PXB-3170 - Test failure in keyring_pxb_2275.sh #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://jira.percona.com/browse/PXB-3170 Test was failing because we were generating an amount of data that was in a range that could cause the server to delete the required redo log. Also the test was failing due to missing redo log file, but we were not checking the error log for that which was a false positive. Fix: Adjusted the test to have a slightly higher redo log capacity. Added a check for the error log to make sure we fail due to missing keyring key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PXB-3170
Test was failing because we were generating an amount of data that was in a range that could cause the server to delete the required redo log. Also the test was failing due to missing redo log file, but we were not checking the error log for that which was a false positive.
Fix:
Adjusted the test to have a slightly higher redo log capacity. Added a check for the error log to make sure we fail due to missing keyring key.