MacOS CI workflows #104
Merged
MacOS CI workflows #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance test results: |
artemgavrilov
commented
Jan 24, 2024
| @@ -18,7 +18,7 @@ AC_DEFUN([REQUIRE_LIB], [ { | |||
| AS_IF([test "x$with_$1" == xdefault], | |||
| [ | |||
| case $host_os in | |||
| darwin*) libpathx=($HOMEBREW_CELLAR/$3/*) | |||
| darwin*) libpathx=($(brew --cellar)/$3/*) | |||
There was a problem hiding this comment.
HOMEBREW_CELLAR variable may be not set (for example in GH CI), so getting desired path directly from brew tool looks more reliable.
artemgavrilov
commented
Jan 24, 2024
Comment on lines
-2431
to
+2437
| # REQUIRE_LIB(name,lib,package,testfn,test_include.h) | ||
| # REQUIRE_LIB(name,lib,package,testfn,test_header_dir,test_include.h) | ||
| # name = The complete name of the library file without the extension. | ||
| # lib = The name of the library file without the 'lib' prefix and without the extension. | ||
| # package = The name of the package that holds the library | ||
| # testfn = One function included in the library that can be used for a test compilation. | ||
| # headerdir = directory that contains required header | ||
| # header = header file to check for | ||
| # headerdir = The directory that contains required header. | ||
| # header = The header file to check for |
There was a problem hiding this comment.
Missed configure script update from previous PR
dAdAbird
approved these changes
Feb 12, 2024
dutow
reviewed
Feb 12, 2024
dutow
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS workflows for
makeandmesonbuilds, including tests.