Updated locking to include locks on files. This is critical to prevent #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parallel updates during the: (a) map entry selection (b) master key rotation. The locks are essentially constructed in a 2PL phase where necessary with an outer lock for the files and the inner one for the cache. Note that we don't need to ever acquire an exclusive lock on the keydata file as the same location can never be selected as long as we selected it via an exclusive lock on the map file.
codeforall
approved these changes
Apr 1, 2024
dutow
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated locking to include locks on files. This is critical to prevent parallel updates during the:
(a) map entry selection
(b) master key rotation.
The locks are essentially constructed in a 2PL phase where necessary with an outer lock for the files and the inner one for the cache.
Note that we don't need to ever acquire an exclusive lock on the keydata file as the same location can never be selected as long as we selected it via an exclusive lock on the map file.