Fix issue-153: Server crash and database corruption #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use the Tuple CID as an IV because it changes when the tuple is deleted. If we have a trigger function that needs the deleted tuple, it will get the wrong IV when decrypting. This happens because the CID used to encrypt the tuple (during INSERT/UPDATE) is different from the CID passed to the decryption function (during delete). To fix this, we need to stop using the CID for IV calculation.
dutow
approved these changes
Apr 2, 2024
dAdAbird
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use the Tuple CID as an IV because it changes when the tuple is deleted. If we have a trigger function that needs the deleted tuple, it will get the wrong IV when decrypting. This happens because the CID used to encrypt the tuple (during INSERT/UPDATE) is different from the CID passed to the decryption function (during delete).
To fix this, we need to stop using the CID for IV calculation.